Bug 2247018 - python-wsaccel fails to build with Python 3.13: error: implicit declaration of function ‘_PyThreadState_UncheckedGet’, ‘_PyDict_GetItem_KnownHash’, ‘_PyDict_NewPresized’, ‘_PyVectorcall_Function’, ‘_PyLong_FromByteArray’, ‘_PyLong_AsByteArray’
Summary: python-wsaccel fails to build with Python 3.13: error: implicit declaration o...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-wsaccel
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Julien Enselme
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-10-30 12:08 UTC by Karolina Surma
Modified: 2024-01-22 11:29 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-01-22 11:29:46 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-10-30 12:08:32 UTC
python-wsaccel fails to build with Python 3.13.0a1.

wsaccel/utf8validator.c: In function ‘__Pyx_PyDict_GetItemStr’:
wsaccel/utf8validator.c:860:55: error: implicit declaration of function ‘_PyDict_GetItem_KnownHash’ [-Werror=implicit-function-declaration]
  860 | #define __Pyx_PyDict_GetItemStrWithError(dict, name)  _PyDict_GetItem_KnownHash(dict, name, ((PyASCIIObject *) name)->hash)

wsaccel/utf8validator.c: In function ‘__pyx_array_new’:
wsaccel/utf8validator.c:848:65: error: implicit declaration of function ‘_PyDict_NewPresized’ [-Werror=implicit-function-declaration]
  848 | #define __Pyx_PyDict_NewPresized(n)  ((n <= 8) ? PyDict_New() : _PyDict_NewPresized(n))
      |                                                                 ^~~~~~~~~~~~~~~~~~~
wsaccel/utf8validator.c: In function ‘__pyx_memoryview_is_slice’:
wsaccel/utf8validator.c:773:39: error: implicit declaration of function ‘_PyThreadState_UncheckedGet’; did you mean ‘PyThreadState_GetUnchecked’? [-Werror=implicit-function-declaration]
  773 |   #define __Pyx_PyThreadState_Current _PyThreadState_UncheckedGet()
      |                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~
wsaccel/utf8validator.c: In function ‘__Pyx_PyObject_FastCallDict’:
wsaccel/utf8validator.c:23188:24: error: implicit declaration of function ‘_PyVectorcall_Function’; did you mean ‘PyVectorcall_Function’? [-Werror=implicit-function-declaration]
23188 |     vectorcallfunc f = _PyVectorcall_Function(func);
      |                        ^~~~~~~~~~~~~~~~~~~~~~
      |                        PyVectorcall_Function
wsaccel/utf8validator.c: In function ‘__Pyx_PyInt_From_int’:
wsaccel/utf8validator.c:27940:16: error: implicit declaration of function ‘_PyLong_FromByteArray’ [-Werror=implicit-function-declaration]
27940 |         return _PyLong_FromByteArray(bytes, sizeof(int),
      |                ^~~~~~~~~~~~~~~~~~~~~
wsaccel/utf8validator.c: In function ‘__Pyx_PyInt_As_int’:
wsaccel/utf8validator.c:28141:23: error: implicit declaration of function ‘_PyLong_AsByteArray’ [-Werror=implicit-function-declaration]
28141 |                 ret = _PyLong_AsByteArray((PyLongObject *)v,
      |                       ^~~~~~~~~~~~~~~~~~~


According to https://docs.python.org/3.13/whatsnew/3.13.html a new public function has been added:

- Add PyThreadState_GetUnchecked() function: similar to PyThreadState_Get(), but don’t kill the process with a fatal error if it is NULL.
The caller is responsible to check if the result is NULL.
Previously, the function was private and known as _PyThreadState_UncheckedGet().
(Contributed by Victor Stinner in gh-108867.)
- removed _PyVectorcall_Function(): use PyVectorcall_Function()
- a lot of private functions have been removed from Python 3.13. The detailed list of the removed private C API functions can be found here: https://github.com/python/cpython/issues/106320

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06578860-python-wsaccel/

For all our attempts to build python-wsaccel with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-wsaccel/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Julien Enselme 2024-01-21 09:53:12 UTC
It seems to work now: https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-wsaccel/ I also tried `mock -r fedora-rawhide-python313 --enablerepo=local python-wsaccel-0.6.6-1.fc40.src.rpm` locally and didn’t encounter any issue. Same in the `python:3.13-rc-bookworm` docker image.


Note You need to log in before you can comment on or make changes to this bug.