Bug 2247277 - Review Request: widevine-installer - Widevine CDM installer for aarch64 systems
Summary: Review Request: widevine-installer - Widevine CDM installer for aarch64 systems
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-10-31 16:24 UTC by Davide Cavalca
Modified: 2023-11-13 01:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-11-12 20:15:36 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+

Attachments (Terms of Use)

Description Davide Cavalca 2023-10-31 16:24:24 UTC 
Spec URL: https://dcavalca.fedorapeople.org/review/widevine-installer/widevine-installer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/widevine-installer/widevine-installer-0^20231031git8fa12dd-1.fc40.src.rpm

Description:
This tool will download and install Widevine systemwide for aarch64 systems. It
performs the necessary configuration changes to make Widevine available for
both Firefox and Chromium-based browsers.

Fedora Account System Username: dcavalca
Comment 1 Davide Cavalca 2023-10-31 16:24:26 UTC 
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=108373995
Comment 2 Neal Gompa 2023-10-31 16:31:14 UTC 
Taking this review.
Comment 3 Neal Gompa 2023-10-31 16:38:44 UTC 
Spec review notes:

> Enhances:       chromium
> Enhances:       firefox 

qt5-qtwebengine and qt6-qtwebengine would also benefit from this.

Note also that "Enhances" is the reverse of "Suggests" and like Suggests does not do anything...
Comment 4 Davide Cavalca 2023-10-31 16:47:32 UTC 
Yeah, I used Enhances on purpose as I wasn't sure if we wanted this to get pulled in automatically with the browsers.
Comment 5 Davide Cavalca 2023-10-31 16:55:22 UTC 
Spec URL: https://dcavalca.fedorapeople.org/review/widevine-installer/widevine-installer.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/widevine-installer/widevine-installer-0^20231031git8fa12dd-1.fc40.src.rpm

Changelog:
- add Enhances for qt5-qtwebengine and qt6-qtwebengine
- ensure /var/lib/widevine gets cleaned up properly on uninstall
- backport upstream patch for /var/lib
Comment 6 Neal Gompa 2023-11-12 13:39:52 UTC 
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.
Comment 7 Fedora Update System 2023-11-12 20:14:02 UTC 
FEDORA-2023-2ab6caf5d3 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-2ab6caf5d3
Comment 8 Fedora Update System 2023-11-12 20:15:36 UTC 
FEDORA-2023-2ab6caf5d3 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 9 Fedora Update System 2023-11-12 20:38:38 UTC 
FEDORA-2023-65f6c448e0 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-65f6c448e0
Comment 10 Fedora Update System 2023-11-12 20:45:26 UTC 
FEDORA-2023-80c2c7c2ec has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-80c2c7c2ec
Comment 11 Fedora Update System 2023-11-13 01:05:15 UTC 
FEDORA-2023-65f6c448e0 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.
Comment 12 Fedora Update System 2023-11-13 01:29:15 UTC 
FEDORA-2023-80c2c7c2ec has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
Note You need to log in before you can comment on or make changes to this bug.