Spec URL: https://trix.fedorapeople.org/rocsparse.spec SRPM URL: https://trix.fedorapeople.org/rocsparse-5.7.1-1.fc40.src.rpm Description: rocSPARSE exposes a common interface that provides Basic Linear Algebra Subroutines for sparse computation implemented on top of AMD's Radeon Open eCosystem Platform ROCm runtime and toolchains. rocSPARSE is created using the HIP programming language and optimized for AMD's latest discrete GPUs. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6591035 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247614-rocsparse/fedora-rawhide-x86_64/06591035-rocsparse/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Ok a few issues: - it's missing "ExclusiveArch: x86_64" - devel package is missing "Requires: %{name}%{?_isa} = %{version}-%{release}" - directory ownership still has issues, see: https://src.fedoraproject.org/rpms/rocm-rpm-macros/pull-request/1
Spec URL: https://trix.fedorapeople.org/rocsparse.spec SRPM URL: https://trix.fedorapeople.org/rocsparse-5.7.1-2.fc40.src.rpm For the exclusive arch and requires changes. For the ownership This change https://src.fedoraproject.org/rpms/rocm-rpm-macros/c/d3ed3ad508df78409a909b30ad3a2693d7398a6c?branch=rawhide > rpm -ql rocm-rpm-macros-modules /usr/lib64/rocm/gfx10/bin /usr/lib64/rocm/gfx10/lib /usr/lib64/rocm/gfx10/lib/cmake /usr/lib64/rocm/gfx11/bin /usr/lib64/rocm/gfx11/lib /usr/lib64/rocm/gfx11/lib/cmake /usr/lib64/rocm/gfx8/bin /usr/lib64/rocm/gfx8/lib /usr/lib64/rocm/gfx8/lib/cmake /usr/lib64/rocm/gfx9/bin /usr/lib64/rocm/gfx9/lib /usr/lib64/rocm/gfx9/lib/cmake /usr/share/licenses/rocm-rpm-macros-modules /usr/share/licenses/rocm-rpm-macros-modules/GPL /usr/share/modulefiles/rocm /usr/share/modulefiles/rocm/default /usr/share/modulefiles/rocm/gfx10 /usr/share/modulefiles/rocm/gfx11 /usr/share/modulefiles/rocm/gfx8 /usr/share/modulefiles/rocm/gfx9 Is where the _libdir/rocm/ dirs are created/owned.
I'm not sure how you got that, but koji show otherwise: https://koji.fedoraproject.org/koji/rpminfo?rpmID=36284342 Noarch should always have libdir as /usr/lib, which is NOT what we want. You need to arch the package (remove the noarch) to make it work, as per my PR: https://src.fedoraproject.org/rpms/rocm-rpm-macros/pull-request/1 This is why the filesystem package, which owns /use/lib64, is arched.
Created attachment 1997078 [details] The .spec file difference from Copr build 6591035 to 6596298
Copr build: https://copr.fedorainfracloud.org/coprs/build/6596298 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247614-rocsparse/fedora-rawhide-x86_64/06596298-rocsparse/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
So I'm going to approve this, by I noticed some rpmlint output that we should be aware of: rocsparse.x86_64: E: shared-library-without-dependency-information /usr/lib64/rocm/gfx9/lib/librocsparse.so.0.1 rocsparse.x86_64: W: no-soname /usr/lib64/rocm/gfx9/lib/librocsparse.so.0.1 I'm not sure the implications of this off the top of my head. I'm also not sure why it's gfx9 specific.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rocsparse