Hi Arnon, I created the storage class, but cloneStrategy is not the 'csi-clone' for me. Could you please take a look?

CNV v4.14.1.rhel9-14 (should already contain the change)
CDI v: $ oc exec $(oc get pod -n openshift-cnv -l=cdi.kubevirt.io=cdi-apiserver --output=jsonpath='{$.items[0].metadata.name}') --namespace=openshift-cnv -- virt-cdi-apiserver --version
Containerized Data Importer v1.57.0-23-g5ab49da26

$ oc get sc trident-csi-fsx -oyaml
allowVolumeExpansion: true
apiVersion: storage.k8s.io/v1
kind: StorageClass
metadata:
  creationTimestamp: "2023-11-22T22:39:19Z"
  name: trident-csi-fsx
  resourceVersion: "10853000"
  uid: 35f2751b-5022-4f89-9cbd-5c20f354a361
parameters:
  backendType: ontap-nas
  fsType: ext4
provisioner: csi.trident.netapp.io
reclaimPolicy: Delete
volumeBindingMode: Immediate


$ oc get storageprofile trident-csi-fsx -oyaml
apiVersion: cdi.kubevirt.io/v1beta1
kind: StorageProfile
metadata:
  creationTimestamp: "2023-11-22T22:39:19Z"
  generation: 1
  labels:
    app: containerized-data-importer
    app.kubernetes.io/component: storage
    app.kubernetes.io/managed-by: cdi-controller
    app.kubernetes.io/part-of: hyperconverged-cluster
    app.kubernetes.io/version: 4.14.1
    cdi.kubevirt.io: ""
  name: trident-csi-fsx
  ownerReferences:
  - apiVersion: cdi.kubevirt.io/v1beta1
    blockOwnerDeletion: true
    controller: true
    kind: CDI
    name: cdi-kubevirt-hyperconverged
    uid: 524cc2cd-f4b7-40c9-af6e-1fdbda005da7
  resourceVersion: "10853002"
  uid: eabd32eb-a6b9-40f7-bd9a-92dd8ec1a364
spec: {}
status:
  claimPropertySets:
  - accessModes:
    - ReadWriteMany
    volumeMode: Filesystem
  cloneStrategy: copy    <----------------------------------------
  dataImportCronSourceFormat: pvc
  provisioner: csi.trident.netapp.io
  storageClass: trident-csi-fsx


Then I noticed that there was no VolumeSnapshotClass, so I created this: 

$ cat trident-volume-snapshot-class.yaml
apiVersion: snapshot.storage.k8s.io/v1
kind: VolumeSnapshotClass
metadata:
  name: csi-snapclass
driver: csi.trident.netapp.io
deletionPolicy: Delete

And it became a 'snapshot'

$ oc get storageprofile trident-csi-fsx -oyaml | grep cloneStrategy
  cloneStrategy: snapshot 

So I'm not sure how to get the 'csi-clone' here. 

A note that might be important: it's a fake storage class, means I don't have an environment to really install it, but the provisioner name is exactly the same.

Hi Jenia, for getting the csi-clone cloneStrategy you need to put 'cloneStrategy: copy' in the StorageProfile spec. To get it actually working you'll also need teh appropriate provisoner CSIDriver. See https://github.com/kubevirt/containerized-data-importer/blob/main/doc/csi-cloning.md.

sorry - put 'cloneStrategy: csi-clone' in the StorageProfile spec :)

IIUC, we expect that the StorageProfile will be automatically populated with 'cloneStrategy: csi-clone'?
But I'm getting 'snapshot' even when I have a csi driver:

$ oc get csidriver | grep trident
csi.trident.netapp.io                   true             false            false             <unset>         false               Persistent             10m

$ oc get storageprofile trident-csi-fsx -oyaml | grep clone
  cloneStrategy: snapshot

Like always, you are right and I was mixing 2 bzs. You sure don't need to put `cloneStrategy: csi-clone` in the spec and the fix was supposed to do it for you. I easily reproduced it on my env. You found an actual bug in the fix.

The fix PR did not get picked up yet d/s.  Pushing to 4.14.2.