Bug 2247917 - Review Request: python-sphinx-argparse-cli - Render CLI arguments defined by the argparse module
Summary: Review Request: python-sphinx-argparse-cli - Render CLI arguments defined by ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2243337
TreeView+ depends on / blocked
 
Reported: 2023-11-04 15:04 UTC by Benson Muite
Modified: 2023-11-14 01:43 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-14 01:43:47 UTC
Type: ---
Embargoed:
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Benson Muite 2023-11-04 15:04:07 UTC
spec: https://download.copr.fedorainfracloud.org/results/fed500/ford/fedora-rawhide-x86_64/06598027-python-sphinx-argparse-cli/python-sphinx-argparse-cli.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/ford/fedora-rawhide-x86_64/06598027-python-sphinx-argparse-cli/python-sphinx-argparse-cli-1.11.1-1.fc40.src.rpm

description:
Render CLI arguments (sub-commands friendly) defined by the argparse
module. For live demo checkout the documentation of tox, pypa-build
and mdpo.

fas: fed500

Reproducible: Always

Comment 1 Benson Muite 2023-11-04 15:08:06 UTC
Koji build:
https://koji.fedoraproject.org/koji/taskinfo?taskID=108571781

Comment 2 Fedora Review Service 2023-11-05 03:16:15 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6599194
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2247917-python-sphinx-argparse-cli/srpm-builds/06599194/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Benson Muite 2023-11-05 05:20:21 UTC
[fedora-review-service-build]

Comment 4 Zbigniew Jędrzejewski-Szmek 2023-11-05 12:48:31 UTC
In %description:
> checkout
"check out"

It's nicer when %description is wrapped to <=80 columns (currently it's rather narrower).

'Release: %autorelease' and '%autochangelog' are recommended instead of an explicit changelog,
see https://docs.pagure.org/fedora-infra.rpmautospec/opting-in.html

> %{?python_provide:%python_provide python3-%{srcname}}
That's not necessary since a long time
(https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_deprecated_macros).
Esp. if %pyproject macros are used, I don't think it makes sense to specify that.

+ package name is OK
+ latest version
+ license is acceptable for Fedora (MIT)
+ license is specified correctly (in SPDX syntax)
+ builds and installs OK
+ python packaging guidelines are followed
+ P/R/BR look OK (apart from a minor issue noted above)

Package is APPROVED.

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-05 13:45:48 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-sphinx-argparse-cli

Comment 6 Fedora Update System 2023-11-05 18:56:14 UTC
FEDORA-2023-ed38a5eb72 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ed38a5eb72

Comment 7 Fedora Update System 2023-11-06 02:55:05 UTC
FEDORA-2023-ed38a5eb72 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-ed38a5eb72 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-ed38a5eb72

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2023-11-14 01:43:47 UTC
FEDORA-2023-ed38a5eb72 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.