Bug 2248128 - PyQt4 fails to build with Python 3.13: error: ‘PyCFunction_Call’ was not declared in this scope
Summary: PyQt4 fails to build with Python 3.13: error: ‘PyCFunction_Call’ was not decl...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: PyQt4
Version: 40
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Antonio T. sagitter
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2291479 (view as bug list)
Depends On:
Blocks: F41FTBFS F41FailsToInstall PYTHON3.13 2291534
TreeView+ depends on / blocked
 
Reported: 2023-11-06 10:56 UTC by Karolina Surma
Modified: 2024-07-24 15:46 UTC (History)
7 users (show)

Fixed In Version: PyQt4-4.12.3-45.fc39 PyQt4-4.12.3-45.fc40
Clone Of:
Environment:
Last Closed: 2024-07-17 15:15:37 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Karolina Surma 2023-11-06 10:56:34 UTC
PyQt4 fails to build with Python 3.13.0a1.

../../../qpy/QtCore/qpycore_pyqtsignal.cpp:661:24: error: ‘PyCFunction_Call’ was not declared in this scope; did you mean ‘PyCFunction_Type’?
  661 |     PyObject *result = PyCFunction_Call(func, args, kw);
      |                        ^~~~~~~~~~~~~~~~
      |                        PyCFunction_Type

https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06593901-PyQt4/

For all our attempts to build PyQt4 with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/PyQt4/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Antonio T. sagitter 2023-11-11 18:07:51 UTC
Is `PyCFunction_Type` correct?

 PyObject *result = PyCFunction_Type(func, args, kw);

instead of

 PyObject *result = PyCFunction_Call(func, args, kw);

?

Comment 2 Miro Hrončok 2023-11-13 08:37:49 UTC
Not at all. That is just gcc trying to be clever.



https://docs.python.org/3.13/whatsnew/3.13.html says:

"""
Remove functions deprecated in Python 3.9.
...
PyCFunction_Call(): use PyObject_Call() instead.

https://docs.python.org/3.13/c-api/call.html#c.PyObject_Call
"""

Comment 3 Aoife Moloney 2024-02-15 23:03:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 4 Karolina Surma 2024-06-12 14:57:53 UTC
*** Bug 2291479 has been marked as a duplicate of this bug. ***

Comment 5 Fedora Fails To Install 2024-06-19 19:57:28 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 7+ weeks.
This is the first reminder (step 3) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 6 Fedora Fails To Install 2024-07-13 07:59:14 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

This package fails to install and maintainers are advised to take one of the following actions:

 - Fix this bug and close this bugzilla once the update makes it to the repository.
   (The same script that posted this comment will eventually close this bugzilla
   when the fixed package reaches the repository, so you don't have to worry about it.)

or

 - Move this bug to ASSIGNED if you plan on fixing this, but simply haven't done so yet.

or

 - Orphan the package if you no longer plan to maintain it.


If you do not take one of these actions, the process at https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs will continue.
This package may be orphaned in 4+ weeks.
This is the second reminder (step 4) from the policy.

Don't hesitate to ask for help on https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/ if you are unsure how to fix this bug.

Comment 7 Antonio T. sagitter 2024-07-15 19:59:02 UTC
This patch should be correct: https://src.fedoraproject.org/rpms/PyQt4/blob/rawhide/f/PyQt4-fix_function_for_Python3.13.patch

Comment 8 Fedora Update System 2024-07-15 22:49:11 UTC
FEDORA-2024-b97154a3b5 (PyQt4-4.12.3-45.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-b97154a3b5

Comment 9 Fedora Update System 2024-07-15 22:49:12 UTC
FEDORA-2024-0ebe501daa (PyQt4-4.12.3-45.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0ebe501daa

Comment 10 Fedora Update System 2024-07-16 01:26:30 UTC
FEDORA-2024-0ebe501daa has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-0ebe501daa`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-0ebe501daa

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 11 Fedora Update System 2024-07-16 02:10:59 UTC
FEDORA-2024-b97154a3b5 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b97154a3b5`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b97154a3b5

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 12 Fedora Fails To Install 2024-07-17 15:15:37 UTC
Hello,

Please note that this comment was generated automatically by https://pagure.io/releng/blob/main/f/scripts/ftbfs-fti/follow-policy.py
If you feel that this output has mistakes, please open an issue at https://pagure.io/releng/

All subpackages of a package against which this bug was filled are now installable or removed from Fedora 41.

Thanks for taking care of it!

Comment 13 Fedora Update System 2024-07-24 12:11:44 UTC
FEDORA-2024-b97154a3b5 (PyQt4-4.12.3-45.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 14 Fedora Update System 2024-07-24 15:46:42 UTC
FEDORA-2024-0ebe501daa (PyQt4-4.12.3-45.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.