Spec URL: https://kalev.fedorapeople.org/rust-jxl-coding.spec SRPM URL: https://kalev.fedorapeople.org/rust-jxl-coding-0.2.3-1.fc40.src.rpm Description: JPEG XL entropy decoder, part of jxl-oxide. Fedora Account System Username: kalev Note that this package (and the rest of the jxl-oxide crates) aren't the latest upstream version because I've deliberately gone with the version that glycin-loaders expects for now.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6616637 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248919-rust-jxl-coding/fedora-rawhide-x86_64/06616637-rust-jxl-coding/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Please replace these two lines: > %license LICENSE-APACHE > %license LICENSE-MIT With these: %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT Otherwise the built packages will contain these files twice. Other than that, looks good to me! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass (there are no tests) - latest version of the crate is packaged - license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora - license files are included with %license in %files (temporarily included from upstream project on GitHub) - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thanks for the review, Fabio! I fixed %license to use %{crate_instdir} in all jxl crates.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-jxl-coding
FEDORA-2023-f47436d9a6 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f47436d9a6
FEDORA-2023-f47436d9a6 has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.