Bug 2248955 - Review Request: golang-github-alecthomas-kingpin2 - Go command line and flag parser
Summary: Review Request: golang-github-alecthomas-kingpin2 - Go command line and flag ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Mark E. Fuller
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-11-09 20:49 UTC by Mikel Olasagasti Uranga
Modified: 2023-12-01 12:18 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-01 12:18:46 UTC
Type: ---
Embargoed:
mark.e.fuller: fedora-review+


Attachments (Terms of Use)

Description Mikel Olasagasti Uranga 2023-11-09 20:49:58 UTC
Spec URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-alecthomas-kingpin2.spec
SRPM URL: https://mikel.olasagasti.info/tmp/fedora/golang-github-alecthomas-kingpin2-2.3.2-1.fc39.src.rpm
Description: Go command line and flag parser.
Fedora Account System Username: mikelo2

Idea is to deprecate golang-gopkg-alecthomas-kingpin-2

Comment 1 Fedora Review Service 2023-11-09 20:54:24 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6617131
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2248955-golang-github-alecthomas-kingpin2/fedora-rawhide-x86_64/06617131-golang-github-alecthomas-kingpin2/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2023-11-09 20:57:57 UTC
https://src.fedoraproject.org/rpms/golang-gopkg-alecthomas-kingpin-2/pull-request/1 to remove the goaltipath. I'll take care of it once this is approved.

Comment 3 Mark E. Fuller 2023-12-01 01:19:46 UTC
Spec is generated with go2rpm:

- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [x] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi ticket.

Comment 4 Fedora Admin user for bugzilla script actions 2023-12-01 11:38:18 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-alecthomas-kingpin2

Comment 5 Fedora Update System 2023-12-01 12:17:23 UTC
FEDORA-2023-f14309932e has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-f14309932e

Comment 6 Fedora Update System 2023-12-01 12:18:46 UTC
FEDORA-2023-f14309932e has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.