Spec URL: https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06619149-nodejs-undici/nodejs-undici.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06619149-nodejs-undici/nodejs-undici-5.27.2-1.fc40.src.rpm Description: An HTTP/1.1 client, written from scratch for Node.js. Fedora Account System Username: jstanek --- This is part of the effort to remove pre-build WASM blobs from NodeJS. This package is intended to become a dependency of nodejs. It is build as a separate noarch RPM in order to support even the architectures (s390x) that do not provide a native support for compiling into WASM.
Additional info: The package currently applies a patch that was pre-liminary accepted by upstream, but not yet merged: https://github.com/nodejs/undici/pull/2403
Copr build: https://copr.fedorainfracloud.org/coprs/build/6619220 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249060-nodejs-undici/fedora-rawhide-x86_64/06619220-nodejs-undici/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Some minor issues, see below: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This package either needs to depend on nodejs or it needs to own `%{nodejs_sitelib}` in %files. Otherwise, this package won't be installable. - The patch we're carrying needs to have a comment pointing to the upstream proposal. ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/node_modules_20 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 25076 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: nodejs-undici-5.27.2-1.fc40.noarch.rpm nodejs-undici-5.27.2-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_4oi8amu')] checks: 31, packages: 2 nodejs-undici.noarch: W: only-non-binary-in-usr-lib nodejs-undici.spec: W: invalid-url Source2: undici-5.27.2-nm-dev.tgz nodejs-undici.spec: W: invalid-url Source1: undici-5.27.2-nm-prod.tgz nodejs-undici.spec: W: invalid-url Source0: undici-5.27.2-stripped.tar.gz nodejs-undici.noarch: W: hidden-file-or-dir /usr/lib/node_modules_20/undici/node_modules/.bin nodejs-undici.noarch: W: hidden-file-or-dir /usr/lib/node_modules_20/undici/node_modules/.bin nodejs-undici.noarch: W: hidden-file-or-dir /usr/lib/node_modules_20/undici/node_modules/.bin/.bin nodejs-undici.noarch: W: hidden-file-or-dir /usr/lib/node_modules_20/undici/node_modules_prod/.package-lock.json nodejs-undici.noarch: W: files-duplicate /usr/lib/node_modules_20/undici/node_modules_prod/@fastify/busboy/deps/dicer/LICENSE /usr/lib/node_modules_20/undici/node_modules_prod/@fastify/busboy/LICENSE nodejs-undici.noarch: W: dangling-relative-symlink /usr/lib/node_modules_20/undici/node_modules/.bin/.bin ../../node_modules_prod/.bin 2 packages and 0 specfiles checked; 0 errors, 10 warnings, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "nodejs-undici". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 31, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.0 s Requires -------- nodejs-undici (rpmlib, GLIBC filtered): Provides -------- nodejs-undici: bundled(llhttp) bundled(nodejs-@fastify/busboy) nodejs-undici npm(undici) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --no-colors --prebuilt --rpm-spec --name nodejs-undici --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: C/C++, R, fonts, Ocaml, SugarActivity, Haskell, Perl, Java, Python, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
(In reply to Stephen Gallagher from comment #3) > Issues: > ======= > - This package either needs to depend on nodejs or it needs to own > `%{nodejs_sitelib}` in %files. Otherwise, this package won't be installable. Correction – the package would be installable (tested with nodejs-cjs-module-lexer, where I also missed this), but the `%{nodejs_sitelib}` would not be removed on uninstall, instead being kept empty on the system. I'm letting the packages to (co-)own the directory; I really do not wish to tangle the dependencies more (nodejs will depend on them). > - The patch we're carrying needs to have a comment pointing to the upstream > proposal. Added link to the spec file. Spec URL: https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06632093-nodejs-undici/nodejs-undici.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jstanek/nodejs-undici/fedora-rawhide-x86_64/06632093-nodejs-undici/nodejs-undici-5.27.2-3.fc40.src.rpm
Created attachment 1999311 [details] The .spec file difference from Copr build 6619220 to 6632114
Copr build: https://copr.fedorainfracloud.org/coprs/build/6632114 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249060-nodejs-undici/fedora-rawhide-x86_64/06632114-nodejs-undici/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/nodejs-undici
FEDORA-2023-697c9a731c has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-697c9a731c
FEDORA-2023-697c9a731c has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.