Spec URL: https://pagure.io/86box/blob/master/f/86box.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/06626902/86Box-4.0.1-1.src.rpm Description: Emulator of x86-based machines based on PCem. Fedora Account System Username: leo Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=108946263
> Spec URL: https://pagure.io/86box/blob/master/f/86box.spec This leads to a syntax-highlighted HTML rendition of the spec. Please use "raw file" links. > License: GPLv2+ Old Callaway-style tag. The SPDX equivalent of this is "GPL-2.0-or-later". https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_valid_license_short_names > %ifarch i386 x86_64 It'd probably be safer to use the "%{ix86}" macro here instead of just "i386". > %ifarch arm aarch64 Same here - use the "%{arm32}" macro to check for 32-bit ARM architectures. > mkdir -p $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${i}x${i}/apps > ... > desktop-file-install --dir=%{buildroot}%{_datadir}/applications src/unix/assets/net.86box.86Box.desktop Mixed use of %{buildroot} and $RPM_BUILD_ROOT. Please pick one and stick with it. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_using_buildroot_and_optflags_vs_rpm_build_root_and_rpm_opt_flags
Fixed these issues. Spec URL: https://pagure.io/86box/raw/master/f/86box.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/06637672/86Box-4.0.1-1.src.rpm Description: Emulator of x86-based machines based on PCem. Fedora Account System Username: leo Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109051593
Whoops, wrong spec URL. Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/06637672/86Box-4.0.1-1.src.rpm Description: Emulator of x86-based machines based on PCem. Fedora Account System Username: leo Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109051593
Hi Leo, could you update this to v4.1? https://github.com/86Box/86Box/releases/tag/v4.1
Leo, are you still interested in packaging this?
Apologies. Will update ASAP.
Updated to 4.1. Spec URL: Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/07920923/86Box-4.1-1.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=122177932
> Version: 4.1 v4.2 is now available. https://github.com/86Box/86Box/releases/tag/v4.2 > cp src/unix/assets/${i}x${i}/net.86box.86Box.png %{buildroot}%{_datadir}/icons/hicolor/${i}x${i}/apps > [...] > cp src/unix/assets/net.86box.86Box.metainfo.xml %{buildroot}%{_metainfodir} Please use `cp -p` or `install -p` to preserve timestamps. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps
Fixed these issues, thank you! Updated to v4.2 Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/08028425/86Box-4.2-1.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=123555066
Copr build: https://copr.fedorainfracloud.org/coprs/build/8028511 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249395-86box/fedora-rawhide-x86_64/08028511-86Box/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Leo, are you still interested in getting this into Fedora? Could you reupload the SRPM somewhere? The copr build is no longer available. (Also, v4.2.1 is now out.)
My apologies for the extended delay on this. Here is the update. Updated to v5.3 Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/09976311/86Box-5.3-1.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140774381
Created attachment 2121231 [details] The .spec file difference from Copr build 8028511 to 9976318
Copr build: https://copr.fedorainfracloud.org/coprs/build/9976318 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249395-86box/fedora-rawhide-x86_64/09976318-86Box/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
An it be built with USE_QT6?
Yep! Enabled QT6 Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/09976483/86Box-5.3-1.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140776183
Created attachment 2121233 [details] The .spec file difference from Copr build 9976318 to 9976486
Copr build: https://copr.fedorainfracloud.org/coprs/build/9976486 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249395-86box/fedora-rawhide-x86_64/09976486-86Box/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixed a typo in the spec for aarch64 and other non-x86_64 architectures, where it wasn't using QT6 properly. Spec URL: https://pagure.io/86box/raw/master/f/86Box.spec SRPM: https://download.copr.fedorainfracloud.org/results/leo/86box/srpm-builds/09976525/86Box-5.3-1.src.rpm Koji Build: https://koji.fedoraproject.org/koji/taskinfo?taskID=140776481
Created attachment 2121234 [details] The .spec file difference from Copr build 9976486 to 9976532
Copr build: https://copr.fedorainfracloud.org/coprs/build/9976532 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2249395-86box/fedora-rawhide-x86_64/09976532-86Box/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.