Bug 2249819 - flatpak-builder-tests depends on python2
Summary: flatpak-builder-tests depends on python2
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: flatpak-builder
Version: 40
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Debarshi Ray
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON2_EOL
TreeView+ depends on / blocked
 
Reported: 2023-11-15 13:28 UTC by Petr Viktorin (pviktori)
Modified: 2024-07-03 09:34 UTC (History)
5 users (show)

Fixed In Version: flatpak-builder-1.4.3-2.fc41
Clone Of:
Environment:
Last Closed: 2024-07-02 23:16:01 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github flatpak flatpak-builder pull 609 0 None open tests/testpython.py: Covert to Python 3 2024-07-02 23:16:00 UTC

Description Petr Viktorin (pviktori) 2023-11-15 13:28:35 UTC
This file in the `flatpak-builder-tests` package has a python2 shebang, which makes RPM automatically generate a requirement on /usr/bin/python2:

   /usr/libexec/installed-tests/flatpak-builder/testpython.py

Note that Python 2 is deprecated in Fedora, requirements for it should not be added.

Please either
- remove/change the shebang
- remove the file (and anything that needs it) or
- filter out the automatic dependency like this:

  %global __requires_exclude ^/usr/bin/python2$

  (see https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/#_filtering_provides_and_requires_after_scanning . I haven't tested the suggestion.)

Thanks!

Reproducible: Always

Comment 1 Aoife Moloney 2024-02-15 23:04:34 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Miro Hrončok 2024-06-18 20:31:51 UTC
You ASSIGNED this bugzilla half a year ago, could you please remove the dependency?

Comment 3 Timothée Ravier 2024-07-02 09:35:50 UTC
Looks like it's https://github.com/flatpak/flatpak-builder/blob/main/tests/testpython.py

Comment 4 Timothée Ravier 2024-07-02 09:38:02 UTC
https://github.com/flatpak/flatpak-builder/pull/609

Comment 5 Debarshi Ray 2024-07-02 16:18:11 UTC
(In reply to Miro Hrončok from comment #2)
> You ASSIGNED this bugzilla half a year ago, could you please remove the
> dependency?

Let me see if I can backport Timothée's patch.

Comment 6 Debarshi Ray 2024-07-02 23:16:01 UTC
(In reply to Debarshi Ray from comment #5)
> (In reply to Miro Hrončok from comment #2)
> > You ASSIGNED this bugzilla half a year ago, could you please remove the
> > dependency?
> 
> Let me see if I can backport Timothée's patch.

I decided to filter out the automatic Requires on python2 as per Miro's advice:
https://github.com/flatpak/flatpak-builder/pull/609

Comment 7 Miro Hrončok 2024-07-02 23:33:44 UTC
$ rpm -qRp flatpak-builder-tests-1.4.3-2.fc41.x86_64.rpm 
/usr/bin/bash
/usr/bin/sh
flatpak-builder(x86-64) = 1.4.3-2.fc41
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1

Comment 8 Debarshi Ray 2024-07-03 09:34:35 UTC
Thanks for the testing, Miro!


Note You need to log in before you can comment on or make changes to this bug.