Spec URL: https://nphilipp.fedorapeople.org/review/python-rpmautospec-koji/1/python-rpmautospec-koji.spec SRPM URL: https://nphilipp.fedorapeople.org/review/python-rpmautospec-koji/1/python-rpmautospec-koji-0.1.0-1.fc40.src.rpm Description: A Koji plugin for generating RPM releases and changelogs with rpmautospec. Fedora Account System Username: nphilipp
Copr build: https://copr.fedorainfracloud.org/coprs/build/6659443 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250196-python-rpmautospec-koji/fedora-rawhide-x86_64/06659443-python-rpmautospec-koji/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
One issue to address: currently the package has `Obsoletes: koji-builder-plugin-rpmautospec < 0.4` while providing 0.1. This could cause problems with updates. Either Provides: a higher version than the old one it replaces or else have the virtual Provides: use a higher epoch. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 6 files have unknown license. Detailed output of licensecheck in /tmp/2250196-python-rpmautospec-koji/licensecheck.txt [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/koji-builder- plugins/__pycache__(koji-builder-plugins, koji-builder-plugin- rpmautospec, koji-flatpak-builder) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Bad spec filename: /tmp/2250196-python-rpmautospec-koji/srpm- unpacked/python-rpmautospec-koji.spec See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-rpmautospec-koji-0.1.0-1.fc40.noarch.rpm python-rpmautospec-koji-0.1.0-1.fc40.src.rpm ==================================================================================================== rpmlint session starts =================================================================================================== rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpouez53up')] checks: 31, packages: 2 python3-rpmautospec-koji.noarch: W: self-obsoletion koji-builder-plugin-rpmautospec < 0.4 obsoletes koji-builder-plugin-rpmautospec = 0.1.0-1.fc40 python3-rpmautospec-koji.noarch: W: no-documentation ===================================================================== 2 packages and 0 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.4 s ==================================================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-rpmautospec-koji.noarch: E: spelling-error ('changelogs', '%description -l en_US changelogs -> change logs, change-logs, changelings') python3-rpmautospec-koji.noarch: W: self-obsoletion koji-builder-plugin-rpmautospec < 0.4 obsoletes koji-builder-plugin-rpmautospec = 0.1.0-1.fc40 python3-rpmautospec-koji.noarch: W: python-missing-require koji python3-rpmautospec-koji.noarch: W: python-missing-require rpmautospec python3-rpmautospec-koji.noarch: W: python-missing-require rpmautospec_core python3-rpmautospec-koji.noarch: W: no-documentation 1 packages and 0 specfiles checked; 1 errors, 5 warnings, 3 filtered, 1 badness; has taken 0.0 s Source checksums ---------------- https://github.com/fedora-infra/rpmautospec-koji/releases/download/0.1.0/rpmautospec_koji-0.1.0.tar.gz : CHECKSUM(SHA256) this package : eb7482f57747863c12d399beb91ba4235fb829e033ee33ed3a6319596482537b CHECKSUM(SHA256) upstream package : febca9ecca50abe68961889145a5ce13c5dc0a05a7f168d4c83563b9013a7e58 However, diff -r shows no differences Requires -------- python3-rpmautospec-koji (rpmlib, GLIBC filtered): (python3.12dist(koji) < 2~~ with python3.12dist(koji) >= 1.33) (python3.12dist(rpmautospec-core) < 0.2~~ with python3.12dist(rpmautospec-core) >= 0.1) koji-builder-plugins python(abi) python3.12dist(rpmautospec) Provides -------- python3-rpmautospec-koji: koji-builder-plugin-rpmautospec python-rpmautospec-koji python3-rpmautospec-koji python3.12-rpmautospec-koji python3.12dist(rpmautospec-koji) python3dist(rpmautospec-koji) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2250196 Buildroot used: fedora-rawhide-aarch64 Active plugins: Generic, Shell-api, Python Disabled plugins: R, SugarActivity, Perl, Haskell, Java, PHP, Ocaml, fonts, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
> One issue to address: currently the package has `Obsoletes: koji-builder-plugin-rpmautospec < 0.4` while providing 0.1. This could cause problems with updates. Either Provides: a higher version than the old one it replaces or else have the virtual Provides: use a higher epoch. As the package names are different, it won't be an issue.
Oh I see, it's an Obsoletes+Provides pair. Then yes, it should probably have `1:` on the ver-rel in the pair.
Spec URL: https://nphilipp.fedorapeople.org/review/python-rpmautospec-koji/2/python-rpmautospec-koji.spec SRPM URL: https://nphilipp.fedorapeople.org/review/python-rpmautospec-koji/2/python-rpmautospec-koji-0.4.0-1.fc40.src.rpm As discussed with Stephen, this bumps the version to match the corresponding python-rpmautospec package.
Created attachment 2002160 [details] The .spec file difference from Copr build 6659443 to 6708797
Copr build: https://copr.fedorainfracloud.org/coprs/build/6708797 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250196-python-rpmautospec-koji/fedora-rawhide-x86_64/06708797-python-rpmautospec-koji/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me now.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-rpmautospec-koji