Bug 2250313 - Review Request: kdsingleapplication - KDAB's helper class for single-instance policy applications
Summary: Review Request: kdsingleapplication - KDAB's helper class for single-instance...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-11-17 17:01 UTC by Ondrej Mosnáček
Modified: 2023-11-27 10:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-27 10:30:42 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Ondrej Mosnáček 2023-11-17 17:01:08 UTC
Spec URL: https://gitlab.com/omos/fedora-package-review/-/raw/099f43dd3285beb8c7c796e484f1ae80d77cdef1/kdsingleapplication/kdsingleapplication.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/omos/kdsingleapplication/fedora-rawhide-x86_64/06662422-kdsingleapplication/kdsingleapplication-1.0.0-1.fc40.src.rpm
Description: KDSingleApplication is a helper class for single-instance policy applications written by KDAB.
Fedora Account System Username: omos

This package is currently bundled in strawberry, but after recent changes it can be reasonably packaged in Fedora, so I'm working on unbundling it. The patch to unbundle it from strawberry can be found at [1] and a successful unbundled COPR build is at [2].

[1] https://src.fedoraproject.org/fork/omos/rpms/strawberry/c/299ee010e79145329987bf6512482665526da519?branch=unbundle-kdsingleapplication
[2] https://copr.fedorainfracloud.org/coprs/omos/kdsingleapplication/builds/

Comment 1 Fedora Review Service 2023-11-17 17:15:09 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6662735
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2250313-kdsingleapplication/fedora-rawhide-x86_64/06662735-kdsingleapplication/fedora-review/review.txt

Please take a look if any issues were found.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Ondrej Mosnáček 2023-11-26 11:57:57 UTC
Hi @eclipseo, as a co-maintainer of strawberry maybe you'd be interested in reviewing this package? :)

Comment 3 Neal Gompa 2023-11-26 15:38:41 UTC
Review notes:

* Package follows Fedora Packaging Guidelines, with one exception
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note: Your soversion handling for libraries is not quite right. ".so.%{soversion}*" should be ".so.%{soversion}{,.*}" instead. Please fix this on import.

PACKAGE APPROVED.

Comment 4 Ondrej Mosnáček 2023-11-27 09:47:22 UTC
Thanks, Neal! Will do.

Comment 5 Fedora Admin user for bugzilla script actions 2023-11-27 09:47:59 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/kdsingleapplication

Comment 6 Fedora Update System 2023-11-27 10:28:52 UTC
FEDORA-2023-e4033ac7e6 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-e4033ac7e6

Comment 7 Fedora Update System 2023-11-27 10:30:42 UTC
FEDORA-2023-e4033ac7e6 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.