Bug 225038 - Review Request: medit - Another very nice Gtk+ text editor
Review Request: medit - Another very nice Gtk+ text editor
Status: CLOSED WONTFIX
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Chitlesh GOORAH
Fedora Package Reviews List
:
Depends On:
Blocks: FE-DEADREVIEW
  Show dependency treegraph
 
Reported: 2007-01-27 13:04 EST by Damien Durand
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-06-15 13:59:03 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Damien Durand 2007-01-27 13:04:30 EST
Spec URL: http://glive.tuxfamily.org/fedora/medit/medit.spec
SRPM URL: http://glive.tuxfamily.org/fedora/medit/medit-0.8.1-1.src.rpm
Description: medit is a multiplatform GTK text editor. Started originally as a simple 
built-in editor component in GGAP, it grew up to a real text editor
Comment 1 Xavier Lamien 2007-01-27 14:01:02 EST
In fields %install,
in your "desktop-file-install" line commande, "--delete-original" was pasted
twice...?

"--vendor=Fedora" is not required anymore, juste set --vendor="".

you shoudn't past all BuildRequires on the same line.
Comment 2 Michael Schwendt 2007-01-27 15:59:49 EST
* must not include /usr/share/icons/hicolor/icon-theme.cache

* missing scriptlets for gtk-update-icon-cache (hicolor icons)
  http://fedoraproject.org/wiki/Packaging/ScriptletSnippets

* must not include /usr/share/mime/mime.cache

* contents of /usr/share/mime/ and subdirs are highly questionable
and need a very close look
Comment 3 Damien Durand 2007-02-03 11:33:38 EST
new changes
- Fix desktop-file
- Add post and postun section about gtk-update-icon-cache and mimeinfo
- Fix files section

New Spec : http://glive.tuxfamily.org/fedora/medit/medit.spec
New SRPM : http://glive.tuxfamily.org/fedora/medit/medit-0.8.1-2.src.rpm

Comment 4 Chitlesh GOORAH 2007-02-03 15:53:27 EST
You should probably look at these 
chitlesh(SPECS)[0]$rpmlint /home/chitlesh/rpmbuild/RPMS/i386/medit-0.8.1-2.i386.rpm
E: medit only-non-binary-in-usr-lib
E: medit standard-dir-owned-by-package /usr/share/icons
E: medit non-executable-script /usr/lib/moo/plugins/lib/pyconsole.py 0644
E: medit zero-length /usr/share/mime/XMLnamespaces
E: medit zero-length /usr/share/mime/aliases
E: medit zero-length /usr/lib/moo/plugins/project/mprj/test.py
E: medit non-executable-script /usr/share/moo/language-specs/check.sh 0644


(In reply to comment #1)
> "--vendor=Fedora" is not required anymore, juste set --vendor="".

you should probably take note of this as well

what's the difference between mooedit and medit ???
 

Comment 5 Michael Schwendt 2007-02-04 07:50:37 EST
> contents of /usr/share/mime/ and subdirs are highly
> questionable and need a very close look

Please do investigate as why your package includes files which
belong elsewhere or are generated at run-time:

-rw-r--r--  /usr/share/mime/XMLnamespaces
-rw-r--r--  /usr/share/mime/aliases
-rw-r--r--  /usr/share/mime/globs
-rw-r--r--  /usr/share/mime/magic
-rw-r--r--  /usr/share/mime/subclasses

Also on your system, these files do exist already.
Comment 6 Jens Petersen 2007-03-19 00:44:38 EDT
When I try to install medit-0.8.1-2.i386 I get:

        file /usr/share/mime/globs from install of medit-0.8.1-2 conflicts with
file from package monodevelop-0.12-7.fc6
Comment 7 Michael Schwendt 2007-03-19 06:33:00 EDT
That is also a packaging bug in monodevelop then, as the file must
not be included.
Comment 8 Chitlesh GOORAH 2007-04-26 06:06:20 EDT
Ping Damien?
Comment 9 Chitlesh GOORAH 2007-06-12 05:21:16 EDT
It's nearly two months now, since my last ping.
I'll be closing this bug as WONTFIX, if I hear no news from DamienDurand till 
15 June 2007.

PS: fedora contributors who are away for a long time should fill up their 
absence in: http://fedoraproject.org/wiki/Vacation
Comment 10 Chitlesh GOORAH 2007-06-15 13:59:03 EDT
Closing !

Note You need to log in before you can comment on or make changes to this bug.