Bug 2250844 - python-Traits fails to build with Python 3.13: traits/ctraits.c:811:5: error: implicit declaration of function ‘Py_TRASHCAN_SAFE_BEGIN’; did you mean ‘Py_TRASHCAN_BEGIN’? [-Werror=implicit-function-declaration]
Summary: python-Traits fails to build with Python 3.13: traits/ctraits.c:811:5: error:...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-Traits
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Orion Poplawski
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 2291600 (view as bug list)
Depends On:
Blocks: F41FTBFS F41FailsToInstall PYTHON3.13 2291477 2291687 2291781 2291954
TreeView+ depends on / blocked
 
Reported: 2023-11-21 12:36 UTC by Karolina Surma
Modified: 2024-06-14 13:50 UTC (History)
5 users (show)

Fixed In Version: python-Traits-6.4.3-2.fc41
Clone Of:
Environment:
Last Closed: 2024-06-14 13:50:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github enthought traits issues 1765 0 None open Fails to build with python 3.13 2024-01-30 04:55:21 UTC
Github enthought traits pull 1767 0 None Merged Fix Traits build error on Python 3.13 2024-06-14 13:49:59 UTC

Description Karolina Surma 2023-11-21 12:36:49 UTC
python-Traits fails to build with Python 3.13.0a1.

traits/ctraits.c: In function ‘has_traits_dealloc’:
traits/ctraits.c:811:5: error: implicit declaration of function ‘Py_TRASHCAN_SAFE_BEGIN’; did you mean ‘Py_TRASHCAN_BEGIN’? [-Werror=implicit-function-declaration]
  811 |     Py_TRASHCAN_SAFE_BEGIN(obj);
      |     ^~~~~~~~~~~~~~~~~~~~~~
      |     Py_TRASHCAN_BEGIN
traits/ctraits.c:814:5: error: implicit declaration of function ‘Py_TRASHCAN_SAFE_END’; did you mean ‘Py_TRASHCAN_END’? [-Werror=implicit-function-declaration]
  814 |     Py_TRASHCAN_SAFE_END(obj);
      |     ^~~~~~~~~~~~~~~~~~~~
      |     Py_TRASHCAN_END

According to https://docs.python.org/3.13/whatsnew/3.13.html:
Remove the old trashcan macros Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END.
They should be replaced by the new macros Py_TRASHCAN_BEGIN and Py_TRASHCAN_END.
The new macros were added in Python 3.8 and the old macros were deprecated in Python 3.11.
(Contributed by Irit Katriel in gh-105111.)


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06660921-python-Traits/

For all our attempts to build python-Traits with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-Traits/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:05:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Karolina Surma 2024-06-12 15:08:55 UTC
*** Bug 2291600 has been marked as a duplicate of this bug. ***


Note You need to log in before you can comment on or make changes to this bug.