Spec URL: https://jjames.fedorapeople.org/g4music/g4music.spec SRPM URL: https://jjames.fedorapeople.org/g4music/g4music-3.4.1-1.fc40.src.rpm Fedora Account System Username: jjames Description: G4Music is a fast fluent lightweight music player written in GTK4, with a beautiful and adaptive user interface. It focuses on high performance for large music collections. Features: - Supports most music file types, samba and any other remote protocol (depends on GIO and GStreamer). - Fast loading and parsing thousands of music files in a few seconds, monitors local changes. - Low memory usage for large music collections with album covers (embedded and external), no thumbnail caches to store. - Groups and sorts by album/artist/title, shuffle list, full-text searching. - Gaussian blurred cover as background, follows GNOME light/dark mode. - Drag-drop from GNOME Files, showing music in Files. - Supports audio peaks visualizer. - Supports gapless playback. - Supports normalizing volume with ReplayGain. - Supports pipewire and other audio sink. - Supports MPRIS control.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6680986 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251092-g4music/fedora-rawhide-x86_64/06680986-g4music/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU General Public License, Version 3", "GNU General Public License v3.0 or later", "GNU Library General Public License v2 or later". 86 files have unknown license. Detailed output of licensecheck in /home/fedora/2251092-g4music/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2396 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: g4music-3.4.1-1.fc40.aarch64.rpm g4music-debuginfo-3.4.1-1.fc40.aarch64.rpm g4music-debugsource-3.4.1-1.fc40.aarch64.rpm g4music-3.4.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpybnwak_k')] checks: 31, packages: 4 g4music.aarch64: W: no-manual-page-for-binary g4music 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 0 badness; has taken 0.6 s Rpmlint (debuginfo) ------------------- Checking: g4music-debuginfo-3.4.1-1.fc40.aarch64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuwzdsec1')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 g4music.aarch64: E: spelling-error ('gapless', '%description -l en_US gapless -> hapless, sapless, napless') g4music.aarch64: E: spelling-error ('pipewire', '%description -l en_US pipewire -> pipe wire, pipe-wire, pipework') g4music.aarch64: W: no-manual-page-for-binary g4music 3 packages and 0 specfiles checked; 2 errors, 1 warnings, 13 filtered, 2 badness; has taken 0.6 s Source checksums ---------------- https://gitlab.gnome.org/neithern/g4music/-/archive/v3.4-1/g4music-3.4.1.tar.gz : CHECKSUM(SHA256) this package : 4f86447f5d432acaca57129ce74a8855f8e1ed77e41f1dff22a62df670382d4f CHECKSUM(SHA256) upstream package : 4f86447f5d432acaca57129ce74a8855f8e1ed77e41f1dff22a62df670382d4f Requires -------- g4music (rpmlib, GLIBC filtered): dbus-common hicolor-icon-theme ld-linux-aarch64.so.1()(64bit) libadwaita-1.so.0()(64bit) libadwaita-1.so.0(LIBADWAITA_1_0)(64bit) libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgraphene-1.0.so.0()(64bit) libgstreamer-1.0.so.0()(64bit) libgsttag-1.0.so.0()(64bit) libgtk-4.so.1()(64bit) libpango-1.0.so.0()(64bit) rtld(GNU_HASH) g4music-debuginfo (rpmlib, GLIBC filtered): g4music-debugsource (rpmlib, GLIBC filtered): Provides -------- g4music: application() application(com.github.neithern.g4music.desktop) g4music g4music(aarch-64) metainfo() metainfo(com.github.neithern.g4music.appdata.xml) mimehandler(audio/wav) mimehandler(audio/webm) mimehandler(audio/x-aac) mimehandler(audio/x-aiff) mimehandler(audio/x-ape) mimehandler(audio/x-flac) mimehandler(audio/x-it) mimehandler(audio/x-m4a) mimehandler(audio/x-m4b) mimehandler(audio/x-matroska) mimehandler(audio/x-mod) mimehandler(audio/x-mp1) mimehandler(audio/x-mp2) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-mpg) mimehandler(audio/x-ms-asf) mimehandler(audio/x-ms-asx) mimehandler(audio/x-ms-wax) mimehandler(audio/x-ms-wma) mimehandler(audio/x-musepack) mimehandler(audio/x-opus+ogg) mimehandler(audio/x-pn-aiff) mimehandler(audio/x-pn-au) mimehandler(audio/x-pn-realaudio) mimehandler(audio/x-pn-realaudio-plugin) mimehandler(audio/x-pn-wav) mimehandler(audio/x-pn-windows-acm) mimehandler(audio/x-real-audio) mimehandler(audio/x-realaudio) mimehandler(audio/x-s3m) mimehandler(audio/x-sbc) mimehandler(audio/x-scpls) mimehandler(audio/x-shorten) mimehandler(audio/x-speex) mimehandler(audio/x-stm) mimehandler(audio/x-tta) mimehandler(audio/x-vorbis) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wav) mimehandler(audio/x-wavpack) mimehandler(audio/x-xm) g4music-debuginfo: debuginfo(build-id) g4music-debuginfo g4music-debuginfo(aarch-64) g4music-debugsource: g4music-debugsource g4music-debugsource(aarch-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251092 Buildroot used: fedora-rawhide-aarch64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Java, fonts, SugarActivity, PHP, Python, Ocaml, Haskell, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Builds on all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=109455615 b) Approved
Hi Benson. Thanks for the review! Is there anything I can do for you? Regarding desktop-file-validate, the %check script actually runs that. I should have pointed that out in the bug description. Sorry for the omission. I did leave a comment in %check, though. The upstream tests run all 3 of desktop-file-validate, appstream-util validate, and glib-compile-schemas --strict --dry-run. I had to change "appstream-util validate" to "appstream-util validate-relax", however, due to what appears to be a bug in appstream-util. I will investigate and file a bug if appropriate.
The Pagure repository was created at https://src.fedoraproject.org/rpms/g4music
FEDORA-2023-b009b2c85c has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-b009b2c85c
FEDORA-2023-0cefe66818 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-0cefe66818
FEDORA-2023-b009b2c85c has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-b009b2c85c \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b009b2c85c See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-0cefe66818 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0cefe66818 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0cefe66818 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-b009b2c85c has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-0cefe66818 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.