Spec URL: https://decathorpe.fedorapeople.org/elementary-calculator.spec SRPM URL: https://decathorpe.fedorapeople.org/elementary-calculator-2.0.2-1.fc39.src.rpm Description: A simple calculator for everyday use. It supports basic and some scientific calculations, including trigonometry functions (sin, cos, and tan). Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109416923
Copr build: https://copr.fedorainfracloud.org/coprs/build/6681016 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251096-elementary-calculator/fedora-rawhide-x86_64/06681016-elementary-calculator/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6685583 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251096-elementary-calculator/fedora-rawhide-x86_64/06685583-elementary-calculator/fedora-review/review.txt Found issues: - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-calculator Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-calculator See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License v3.0 or later". 201 files have unknown license. Detailed output of licensecheck in /home/fedora/2251096-elementary- calculator/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [ ]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES [ ]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES [ ]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [ ]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 701 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: elementary-calculator-2.0.2-1.fc40.x86_64.rpm elementary-calculator-debuginfo-2.0.2-1.fc40.x86_64.rpm elementary-calculator-debugsource-2.0.2-1.fc40.x86_64.rpm elementary-calculator-2.0.2-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpah7ksxd0')] checks: 31, packages: 4 elementary-calculator.x86_64: W: no-manual-page-for-binary io.elementary.calculator elementary-calculator.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.calculator.mo elementary-calculator.x86_64: E: files-duplicated-waste 117697 elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.calculator.svg 4 packages and 0 specfiles checked; 2 errors, 7 warnings, 2 badness; has taken 0.5 s Rpmlint (debuginfo) ------------------- Checking: elementary-calculator-debuginfo-2.0.2-1.fc40.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp6aadii0s')] checks: 31, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.1 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 elementary-calculator.x86_64: W: no-manual-page-for-binary io.elementary.calculator elementary-calculator.x86_64: E: invalid-lc-messages-dir /usr/share/locale/mo/LC_MESSAGES/io.elementary.calculator.mo elementary-calculator.x86_64: E: files-duplicated-waste 117697 elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/128x128@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/128x128/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/16x16@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/16x16/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/24x24@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/24x24/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/32x32@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/32x32/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/48x48@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/48x48/apps/io.elementary.calculator.svg elementary-calculator.x86_64: W: files-duplicate /usr/share/icons/hicolor/64x64@2/apps/io.elementary.calculator.svg /usr/share/icons/hicolor/64x64/apps/io.elementary.calculator.svg 3 packages and 0 specfiles checked; 2 errors, 7 warnings, 13 filtered, 2 badness; has taken 0.6 s Source checksums ---------------- https://github.com/elementary/calculator/archive/2.0.2/calculator-2.0.2.tar.gz : CHECKSUM(SHA256) this package : dd89a3a420af0515c78831d5d388b56ca3870cc3462f9f01ccc6887244dfcf56 CHECKSUM(SHA256) upstream package : dd89a3a420af0515c78831d5d388b56ca3870cc3462f9f01ccc6887244dfcf56 Requires -------- elementary-calculator (rpmlib, GLIBC filtered): hicolor-icon-theme libc.so.6()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgranite-7.so.7()(64bit) libgtk-4.so.1()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) elementary-calculator-debuginfo (rpmlib, GLIBC filtered): elementary-calculator-debugsource (rpmlib, GLIBC filtered): Provides -------- elementary-calculator: application() application(io.elementary.calculator.desktop) elementary-calculator elementary-calculator(x86-64) metainfo() metainfo(io.elementary.calculator.metainfo.xml) elementary-calculator-debuginfo: debuginfo(build-id) elementary-calculator-debuginfo elementary-calculator-debuginfo(x86-64) elementary-calculator-debugsource: elementary-calculator-debugsource elementary-calculator-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2251096 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, Perl, Python, PHP, C/C++, R, fonts, Ocaml, SugarActivity, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Builds on all architectures: https://koji.fedoraproject.org/koji/taskinfo?taskID=109416923 b) Might update changelog comment to indicate it is for unretirement c) The directories /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES have no owners. Is this a bug in %find_lang %{appname} ? d) SVG icons usually go in /usr/share/icons/hicolor/scalable e) Can tests be run?
Thanks for the review! (In reply to Benson Muite from comment #5) > Comments: > a) Builds on all architectures: > https://koji.fedoraproject.org/koji/taskinfo?taskID=109416923 > b) Might update changelog comment to indicate it is for unretirement The package used to use rpmautospec before unretirement, so the changelog message right now will be thrown away anyway when I import it. > c) The directories > /usr/share/locale/mo, /usr/share/locale/mo/LC_MESSAGES > have no owners. Is this a bug in %find_lang %{appname} ? No, it's not a bug in %find_lang, it's a bug in the filesystem package: https://bugzilla.redhat.com/show_bug.cgi?id=2251577 > d) SVG icons usually go in /usr/share/icons/hicolor/scalable Not necessarily. These ones are size-specific, but provided in a vector graphics format. The non-"scalable" icons don't *have* to be in bitmap formats. > e) Can tests be run? Yes. I added `%meson_test` to the %check section and tests pass in a local build.
Thanks. Can approve once bug 2251577 is fixed. Alternatively, may wish to own those directories, until bug 2251577 is fixed.
A lot of packages ship locale files that aren't (yet) in owned directories - why is this a blocking issue? This will get resolved as soon as the filesystem package is fixed, not requiring any changes on this package's side.
Owning all directories is under MUST items. Should review guidelines be updated and/or is fedora-review incorrect for this and not following current practice?
(In reply to Benson Muite from comment #9) > Owning all directories is under MUST items. Should review guidelines be > updated > and/or is fedora-review incorrect for this and not following current > practice? This is one of those things that should generally be owned centrally, and co-ownership can cause problems with things like permissions. So it's fine to let this go and prod the owner of the filesystem package to extend the directories owned there.
Approved.
Thanks! https://pagure.io/releng/issue/11833
pasted the wrong link, here's the correct one: https://pagure.io/releng/issue/11834
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-f143c72f88