Bug 2251101 - Review Request: elementary-camera - Camera app designed for elementary
Summary: Review Request: elementary-camera - Camera app designed for elementary
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/camera
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-11-22 22:08 UTC by Fabio Valentini
Modified: 2023-11-27 15:29 UTC (History)
2 users (show)

Fixed In Version: elementary-camera-6.2.2-1.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-11-27 15:29:33 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-11-22 22:08:45 UTC
Spec URL: https://decathorpe.fedorapeople.org/elementary-camera.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-camera-6.2.2-1.fc39.src.rpm

Description:
Camera is a simple app to take photos with a webcam.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-11-22 22:08:48 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109417474

Comment 2 Fedora Review Service 2023-11-22 22:29:39 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6681037
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251101-elementary-camera/fedora-rawhide-x86_64/06681037-elementary-camera/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-11-26 01:47:08 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

Note, it looks like the "mo" locale directories is un-owned and needs to be handled somewhere: /usr/share/locale/mo/LC_MESSAGES, /usr/share/locale/mo

This probably needs to be handled in "filesystem".

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2023-11-26 17:25:11 UTC
Thank you for the review!

I've added a comment about the unowned directories for "mo" locale to this bug:
https://bugzilla.redhat.com/show_bug.cgi?id=2251577

Comment 5 Fabio Valentini 2023-11-26 17:27:22 UTC
https://pagure.io/releng/issue/11808

Comment 6 Fabio Valentini 2023-11-27 15:29:33 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-8e0e15bbb4


Note You need to log in before you can comment on or make changes to this bug.