Spec URL: https://decathorpe.fedorapeople.org/elementary-code.spec SRPM URL: https://decathorpe.fedorapeople.org/elementary-code-7.1.0-1.fc39.src.rpm Description: Code editor from elementary. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=109417912
Copr build: https://copr.fedorainfracloud.org/coprs/build/6681298 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251104-elementary-code/fedora-rawhide-x86_64/06681298-elementary-code/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint Note, it looks like the "ro_MD" locale directories is un-owned and needs to be handled somewhere: /usr/share/locale/ro_MD/LC_MESSAGES, /usr/share/locale/ro_MD This probably needs to be handled in "filesystem". Additionally, /usr/share/polkit-1 and /usr/share/polkit-1/actions are owned by polkit and this should require that package. This adjustment can be made on import. PACKAGE APPROVED.
Thank you for the review! I've filed a bug against the "filesystem" package: https://bugzilla.redhat.com/show_bug.cgi?id=2251577 And will address the missing "Requires: polkit" before re-importing the package.
https://pagure.io/releng/issue/11807
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-b2284dc561