Spec URL: https://aleasto.fedorapeople.org/reviews/plasma-print-manager/plasma-print-manager.spec SRPM URL: https://aleasto.fedorapeople.org/reviews/plasma-print-manager/plasma-print-manager-5.27.80-1.fc40.src.rpm Description: Printer management for KDE Fedora Account System Username:
Copr build: https://copr.fedorainfracloud.org/coprs/build/6685806 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251279-plasma-print-manager/fedora-rawhide-x86_64/06685806-plasma-print-manager/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Initial review: > %{_libdir}/libkcupslib.so This library needs to be in a subdirectory if it's truly a private library. Otherwise its symbols will be part of the global symbol cache and that can be problematic.
Proposed change upstream and tracking the patch downstream for now. Spec URL: https://aleasto.fedorapeople.org/reviews/plasma-print-manager/plasma-print-manager.spec SRPM URL: https://aleasto.fedorapeople.org/reviews/plasma-print-manager/plasma-print-manager-5.27.80-1.fc40.src.rpm
Review notes: * Package follows Fedora Packaging Guidelines * Package builds and installs * Package licensing is correctly handled * No serious issues from rpmlint PACKAGE APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/plasma-print-manager