Spec URL: https://download.copr.fedorainfracloud.org/results/shattuckite/bornagain/fedora-rawhide-x86_64/06694951-libformfactor/libformfactor.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/shattuckite/bornagain/fedora-rawhide-x86_64/06694951-libformfactor/libformfactor-0.3.1-1.fc40.src.rpm

Copr build:
https://copr.fedorainfracloud.org/coprs/build/6700412
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251524-libformfactor/srpm-builds/06700412/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

License:        GPL-3.0-or-later

Add a comment in the spec about this from the licensecheck.txt
Boost Software License 1.0                                                                                                        
--------------------------                                                                                                        
libformfactor-v0.3.1/test/3rdparty/catch.hpp 

%description
Improve this.
Use at least the first line of readme, include the references
https://journals.iucr.org/j/issues/2021/02/00/vg5135/index.html
In your description use the paper author's full name Joachim Wuttkea.

-DCMAKE_BUILD_TYPE=Release
Should be RelWithDebInfo

Spec URL: https://download.copr.fedorainfracloud.org/results/shattuckite/review/fedora-rawhide-x86_64/06844262-libformfactor/libformfactor.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/shattuckite/review/fedora-rawhide-x86_64/06844262-libformfactor/libformfactor-0.3.1-1.fc40.src.rpm

Thanks for you reviewing. Hope I fixed the all as you suggested.

> -DCMAKE_BUILD_TYPE=Release
> Should be RelWithDebInfo

I see that the RelWithDebInfo should be comparably efficient with Release, but get debug symbols. [1] Is this your reason that I should use RelWithDebInfo?

[1] https://stackoverflow.com/questions/48754619/what-are-cmake-build-type-debug-release-relwithdebinfo-and-minsizerel

Yes, use RelWithDebInfo because a debug rpm is created, and it needs some symbols.  I believe the cflags will get a -g manually added to it which may or may not interact badly with the use of RELEASE.

Thanks for the changes, looks good to go.
Approved.

The Pagure repository was created at https://src.fedoraproject.org/rpms/libformfactor

FEDORA-2024-ea951838c8 has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ea951838c8

FEDORA-2024-ea951838c8 has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.