Spec URL: https://ikkoku.de/github-monaspace-fonts/github-monaspace-fonts.spec SRPM URL: https://ikkoku.de/github-monaspace-fonts/github-monaspace-fonts-1.000-1.fc39.src.rpm Description: The Monaspace type system is a monospaced type superfamily with some modern tricks up its sleeve. It consists of five variable axis typefaces. Each one has a distinct voice, but they are all metrics-compatible with one another, allowing you to mix and match them for a more expressive typographical palette. Fedora Account System Username: suraia
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695820 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251562-github-monaspace-fonts/fedora-rawhide-x86_64/06695820-github-monaspace-fonts/fedora-review/review.txt Found issues: - Documentation size is 973212910 bytes in 180 files. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I have updated the package to remove the large documentation as it added almost 100 MB per package. Spec URL: https://ikkoku.de/github-monaspace-fonts/github-monaspace-fonts.spec SRPM URL: https://ikkoku.de/github-monaspace-fonts/github-monaspace-fonts-1.000-2.fc39.src.rpm
Created attachment 2001553 [details] The .spec file difference from Copr build 6695820 to 6695881
Copr build: https://copr.fedorainfracloud.org/coprs/build/6695881 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2251562-github-monaspace-fonts/fedora-rawhide-x86_64/06695881-github-monaspace-fonts/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I am taking this review. As the upstream has come out with version 1.101, would you like to update the spec to reflect the changes ?
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Sources used to build the package match the upstream source, as provided in the spec URL. Note: Upstream MD5sum check error, diff is in /var/lib/copr- rpmbuild/results/github-monaspace-fonts/diff.txt See: https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ Source checksums ---------------- https://github.com/githubnext/monaspace/releases/download/v1.000/monaspace-v1.000.zip : CHECKSUM(SHA256) this package : 3e08376fd0aeca1f851fde0c08e18ca2d797f6a4c7a449670bf4d1270303c8f6 CHECKSUM(SHA256) upstream package : 5b294f80a98f8d7b35e0d9b1300f137944ee5a0cb3ddc0723a0d173de8d03c90 diff -r also reports differences -- The package in not providing the latest version Please update spec with latest version ===== MUST items ===== Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "SIL Open Font License 1.1". 933 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/github-monaspace-fonts/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 62410 bytes in 10 files. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Spec file according to URL is the same as in SRPM. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. fonts: [x]: Run fc-query on all fonts in package. Sample Pattern has 28 elts (size 32) family: "Monaspace Argon"(s) familylang: "en"(s) style: "Bold Italic"(s) stylelang: "en"(s) fullname: "Monaspace Argon Bold Italic"(s) fullnamelang: "en"(s) slant: 100(i)(s) weight: 200(f)(s) width: 100(f)(s) foundry: "UKWN"(s) file: "MonaspaceArgon-BoldItalic.otf"(s) index: 0(i)(s) outline: True(s) scalable: True(s) charset: 0000: 00000000 ffffffff ffffffff 7fffffff 00000000 ffffffff ffffffff ffffffff 0001: ffffffff fffffdff fffffdff 7fffffff 20048000 00000000 00000000 f0000cc0 0002: 0f000000 008c0000 02000000 00040000 00000000 00000000 3f0000c0 00000000 0003: 00001ddf 000001c8 00000000 00000000 00000000 00000200 00000000 00000000 001e: 00000000 00000000 00000000 00000000 4000003f 33000001 00003c00 030c0030 0020: 77180000 0601004f 00000010 03f10000 000003ff a4021202 00000000 00000000 0021: 00480000 0000000c 78180000 00000000 03ff0000 0c000600 00000050 00000000 0022: 440781cd 00900981 00000100 00000033 00200004 00000000 00000000 00000000 0025: 00000000 00000000 00000000 00000000 00000000 51540000 00000405 00000000 002b: 0003c000 00000000 00000000 00000000 00000000 00000000 00000000 00000000 (s) lang: aa|ay|az-az|bi|bin|br|bs|ca|ch|co|cs|cy|da|de|en|eo|es|et|eu|fi|fj|fo|fr|fur|fy|gd|gl|gv|ho|hr|hu|ia|ig|id|ie|io|is|it|kw|la|lb|lt|lv|mg|mh|mt|nb|nds|nl|nn|no|nr|nso|ny|oc|om|pl|pt|rm|ro|se|sk|sl|sma|smj|smn|so|sq|ss|st|sv|sw|tk|tl|tn|tr|ts|uz|vo|vot|wa|wen|wo|xh|yap|zu|an|crh|csb|fil|hsb|ht|jv|kj|ku-tr|kwm|lg|li|ms|na|ng|pap-an|pap-aw|rn|rw|sc|sg|sn|su|za|agr|ayc|bem|dsb|lij|mfe|mjw|nhn|niu|sgs|szl|tpi|unm|wae|yuw(s) fontversion: 65536(i)(s) capability: "otlayout:DFLT otlayout:latn"(s) fontformat: "CFF"(s) decorative: False(s) postscriptname: "MonaspaceArgon-BoldItalic"(s) color: False(s) symbol: False(s) variable: False(s) fonthashint: False(s) order: 0(i)(s) namedinstance: False(s) fontwrapper: "SFNT"(s) Similar mesage for all fonts Rpmlint ------- Checking: github-monaspace-fonts-all-1.000-2.fc42.noarch.rpm github-monaspace-fonts-1.000-2.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp9dqignvb')] checks: 32, packages: 2 github-monaspace-fonts.src: E: spelling-error ('superfamily', 'Summary(en_US) superfamily -> super family, super-family, superficially') github-monaspace-fonts.src: E: spelling-error ('monospaced', '%description -l en_US monospaced -> mono spaced, mono-spaced, monocled') github-monaspace-fonts.src: E: spelling-error ('superfamily', '%description -l en_US superfamily -> super family, super-family, superficially') github-monaspace-fonts.spec:125: W: setup-not-quiet github-monaspace-fonts-all.noarch: W: no-documentation 2 packages and 0 specfiles checked; 3 errors, 2 warnings, 8 filtered, 3 badness; has taken 1.7 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "github-monaspace-fonts-all". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Requires -------- github-monaspace-fonts-all (rpmlib, GLIBC filtered): github-monaspace-argon-fonts github-monaspace-argon-var-fonts github-monaspace-krypton-fonts github-monaspace-krypton-var-fonts github-monaspace-neon-fonts github-monaspace-neon-var-fonts github-monaspace-radon-fonts github-monaspace-radon-var-fonts github-monaspace-xenon-fonts github-monaspace-xenon-var-fonts Provides -------- github-monaspace-fonts-all: github-monaspace-fonts-all Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.