Bug 2251779 - python-zope-testrunner fails to build with Python 3.13: ImportError: cannot import name '_start_new_thread' from 'threading'
Summary: python-zope-testrunner fails to build with Python 3.13: ImportError: cannot i...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: python-zope-testrunner
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Jerry James
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.13
TreeView+ depends on / blocked
 
Reported: 2023-11-27 14:57 UTC by Karolina Surma
Modified: 2024-05-02 20:14 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github zopefoundation zope.testrunner issues 167 0 None open Tests are broken on Python 3.13a6+ 2024-05-02 20:14:43 UTC

Description Karolina Surma 2023-11-27 14:57:46 UTC
python-zope-testrunner fails to build with Python 3.13.0a1.

This report is automated and not very verbose, but we'll try to get back here with details.

+ python3 -m unittest discover -s zope/testrunner -t .
.........................................E
======================================================================
ERROR: zope.testrunner.tests.test_threadsupport (unittest.loader._FailedTest.zope.testrunner.tests.test_threadsupport)
----------------------------------------------------------------------
ImportError: Failed to import test module: zope.testrunner.tests.test_threadsupport
Traceback (most recent call last):
  File "/usr/lib64/python3.13/unittest/loader.py", line 394, in _find_test_path
    module = self._get_module_from_name(name)
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/lib64/python3.13/unittest/loader.py", line 337, in _get_module_from_name
    __import__(name)
  File "/builddir/build/BUILDROOT/python-zope-testrunner-6.2-1.fc40.x86_64/usr/lib/python3.13/site-packages/zope/testrunner/tests/test_threadsupport.py", line 16, in <module>
    from threading import _start_new_thread
ImportError: cannot import name '_start_new_thread' from 'threading' (/usr/lib64/python3.13/threading.py). Did you mean: '_start_joinable_thread'?


----------------------------------------------------------------------
Ran 42 tests in 0.014s


https://docs.python.org/3.13/whatsnew/3.13.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.13/fedora-rawhide-x86_64/06692273-python-zope-testrunner/

For all our attempts to build python-zope-testrunner with Python 3.13, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/package/python-zope-testrunner/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.13:
https://copr.fedorainfracloud.org/coprs/g/python/python3.13/

Let us know here if you have any questions.

Python 3.13 is planned to be included in Fedora 41.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.13.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Aoife Moloney 2024-02-15 23:05:48 UTC
This bug appears to have been reported against 'rawhide' during the Fedora Linux 40 development cycle.
Changing version to 40.

Comment 2 Michel Lind 2024-02-27 02:37:30 UTC
Looks like only doctests are failing now

Comment 3 Jerry James 2024-03-15 02:30:56 UTC
Yes, there are extra lines of output with python 3.13.  This patch fixes the build with 3.13:

--- zope.testrunner-6.4/src/zope/testrunner/tests/testrunner-subunit.rst.orig	2024-02-27 02:42:53.000000000 -0700
+++ zope.testrunner-6.4/src/zope/testrunner/tests/testrunner-subunit.rst	2024-03-14 20:09:07.806043416 -0600
@@ -495,6 +495,7 @@ Let's run tests including a module with
     Traceback (most recent call last):
       File "/home/benji/workspace/all-the-trunks/zope.testrunner/src/zope/testrunner/testrunner-ex/sample2/sample23/sampletests_i.py", line 17, in <module>
         class Test(unittest.TestCase):
+          ...
       File "/home/benji/workspace/all-the-trunks/zope.testrunner/src/zope/testrunner/testrunner-ex/sample2/sample23/sampletests_i.py", line 22, in Test
         raise TypeError('eek')
     TypeError: eek
--- zope.testrunner-6.4/src/zope/testrunner/tests/testrunner-subunit-v2.rst.orig	2024-02-27 02:42:53.000000000 -0700
+++ zope.testrunner-6.4/src/zope/testrunner/tests/testrunner-subunit-v2.rst	2024-03-14 20:09:20.740858494 -0600
@@ -458,6 +458,7 @@ Let's run tests including a module with
     Traceback (most recent call last):
       File "/home/benji/workspace/all-the-trunks/zope.testrunner/src/zope/testrunner/testrunner-ex/sample2/sample23/sampletests_i.py", line 17, in <module>
         class Test(unittest.TestCase):
+          ...
       File "/home/benji/workspace/all-the-trunks/zope.testrunner/src/zope/testrunner/testrunner-ex/sample2/sample23/sampletests_i.py", line 22, in Test
         raise TypeError('eek')
     TypeError: eek

Sadly, it breaks the build with python 3.12.  Apparently ellipsis does not match zero lines.  I'm not very familiar with python's doctest module.  If somebody knows how to match zero or more lines at that spot, please educate me.


Note You need to log in before you can comment on or make changes to this bug.