+++ This bug was initially created as a clone of Bug #2159966 +++

Description of problem:


ceph version 17.2.5-58.el9cp (16442de8e6d5a0e3579858f2df1407d21043bc4b) quincy (stable)

Further to https://bugzilla.redhat.com/show_bug.cgi?id=2153771#c15

/]# radosgw-admin sync group  create --group-id= --status=allowed
{
    "groups": [
        {
            "id": "",
            "data_flow": {},
            "pipes": [],
            "status": "allowed"
        }
    ]
}

Empty and invalid names should not be allowed in group names.

--- Additional comment from Madhavi Kasturi on 2023-06-13 08:01:39 UTC ---

Hi Matt,

Would this be available in rhcs7.0?

--- Additional comment from Matt Benjamin (redhat) on 2023-07-12 14:05:11 UTC ---

Hi Soumya,

I'm moving this in to 7.0.  Could you help triage?

Matt

--- Additional comment from Soumya Koduri on 2023-07-14 06:16:42 UTC ---

Fix posted for review: https://github.com/ceph/ceph/pull/52445

--- Additional comment from Anuchaithra on 2023-08-03 10:39:57 UTC ---

Hi Soumya,

This behaviour is also seen in sync group remove, with ceph version 17.2.6-100.el9cp

[root@ceph-pri-ci-anrao-x057k-e443fd-node5 ~]# radosgw-admin sync group rm --group-id= --bucket test-bkt-1
{
    "sync_policy": {
        "groups": [
            {
                "id": "bucket1",
                "data_flow": {},
                "pipes": [],
                "status": "allowed"
            }
        ]
    }
}
[root@ceph-pri-ci-anrao-x057k-e443fd-node5 ~]#

[root@ceph-pri-ci-anrao-x057k-e443fd-node5 ~]# radosgw-admin sync group remove --group-id=
{
    "sync_policy": {
        "groups": []
    }
}
[root@ceph-pri-ci-anrao-x057k-e443fd-node5 ~]#

--- Additional comment from Anuchaithra on 2023-08-08 07:39:48 UTC ---

This behaviour is also seen in flow and pipes for both creation and deletion, with ceph version 17.2.6-100.el9cp

--- Additional comment from Soumya Koduri on 2023-08-08 12:45:09 UTC ---

 (In reply to Soumya Koduri from comment #3)
> Fix posted for review: https://github.com/ceph/ceph/pull/52445

This fix addresses all the above commands reported as well.

--- Additional comment from Soumya Koduri on 2023-08-28 09:41:32 UTC ---

Fix cherry-picked to ceph-7.0-rhel-patches (https://gitlab.cee.redhat.com/ceph/ceph/-/commit/3ad3691795d4e9aed2a6108177d75b108368f734)

--- Additional comment from errata-xmlrpc on 2023-08-29 03:34:44 UTC ---

Bug report changed to ON_QA status by Errata System.
A QE request has been submitted for advisory RHBA-2023:118213-01
https://errata.devel.redhat.com/advisory/118213

--- Additional comment from errata-xmlrpc on 2023-08-29 03:34:51 UTC ---

This bug has been added to advisory RHBA-2023:118213 by Thomas Serlin (tserlin)

--- Additional comment from Anuchaithra on 2023-08-31 06:51:52 UTC ---

Verified with ceph version : ceph version 18.2.0-1.el9cp


[root@ceph-pri-anrao-9q70zk-node5 ~]# radosgw-admin sync group  create --group-id= --status=allowed
ERROR: --group-id not specified
[root@ceph-pri-anrao-9q70zk-node5 ~]#


[root@ceph-pri-anrao-9q70zk-node5 ~]# radosgw-admin sync group flow create --group-id=1 --flow-id= --flow-type=symmetrical --zones=primary,secondary
ERROR: --flow-id not specified

[root@ceph-pri-anrao-9q70zk-node5 ~]# radosgw-admin sync group pipe create --group-id=1 --pipe-id= --source-zones='primary,secondary' --dest-zones='*'
WARNING: cannot find source zone id for name=*
ERROR: --pipe-id not specified
[root@ceph-pri-anrao-9q70zk-node5 ~]#


Empty group name is not accepted as expected.


we have also tested with special characters and numbers(@, =, 1) it worked fine for that, is this expected?
# radosgw-admin sync group  create --group-id=1 --status=allowed
# radosgw-admin sync group flow create --group-id=1 --flow-id=@ --flow-type=symmetrical --zones=primary,secondary
# radosgw-admin sync group pipe create --group-id=1 --pipe-id== --source-zones='primary,secondary' --dest-zones='*'
log: https://docs.google.com/document/d/1HAN1RWeUpY3N7t062Wzl6cYbEVRg_SBh0EqykWWmwZ4/edit?usp=sharing

--- Additional comment from daniel parkes on 2023-08-31 09:54:08 UTC ---

Hi, I'm not sure I can answer this one.


 @mbenjamin can someone from your team check, please?.

Thanks

--- Additional comment from Soumya Koduri on 2023-08-31 10:18:49 UTC ---

As of now, `rgw` does not follow any naming conventions while creating any entities internal to it (eg.,`zonegroup`/`realm`/`zones). Same applies for sync policy group as well as these are not part of any S3 spec.

--- Additional comment from Anuchaithra on 2023-09-02 10:26:49 UTC ---

Moving BZ to verified state, based on comment #12

--- Additional comment from Rivka Pollack on 2023-09-10 11:39:15 UTC ---

@skoduri

Please provide the Doc Type and Doc Text in the appropriate fields for the Ceph 7 release notes.
Thank you.