Red Hat Bugzilla – Bug 225239
Merge Review: adjtimex
Last modified: 2007-11-30 17:11:54 EST
Fedora Merge Review: adjtimex
I will review this package.
Look for a full review in a bit.
OK - Spec in American English
OK - Spec is legible.
OK - Sources match upstream md5sum:
OK - BuildRequires correct
OK - Package has %defattr and permissions on files is good.
OK - Package has a correct %clean section.
See below - Package has correct buildroot
OK - Package is code or permissible content.
OK - Packages %doc files don't affect runtime.
OK - Package compiles and builds on at least one arch.
OK - Package has no duplicate files in %files.
OK - Package doesn't own any directories other packages own.
OK - Package owns all the directories it creates.
See below - No rpmlint output.
OK - final provides and requires are sane:
OK - Should build in mock.
OK - Should build on all supported archs
OK - Should function as described.
OK - Should have dist tag
OK - Should package latest version
0 bugs - check for outstanding bugs on package.
1. The License tag is wrong. It should be "GPL", not "distributable"
2. Buildroot is not correct. Use the suggested buildroot.
3. rpmlint says:
rpmlint on ./adjtimex-debuginfo-1.21-1.fc7.i386.rpm
W: adjtimex-debuginfo invalid-license distributable
Fix license tag
W: adjtimex-debuginfo no-url-tag
Should add perhaps:
rpmlint on ./adjtimex-1.21-1.fc7.i386.rpm
W: adjtimex summary-ended-with-dot A utility for adjusting kernel time variables.
Summary shouldn't end in .
All these are pretty minor. Provided you make the above changes, I will
be happy to APPROVE this.
Ok. I didn't add the URL tag as the lsm has old version, but everything else
should be fixed in adjtimex-1.21-2.fc7.
Per the new offical review guidelines I am going to reassign this to me
(the reviewer) and set it closed/rawhide, since the changes are already there.