Bug 2252746 - Review Request: rust-serde-untagged - Serde Visitor implementation for deserializing untagged enums
Summary: Review Request: rust-serde-untagged - Serde Visitor implementation for deseri...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Josh Stone
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/serde-untagged
Whiteboard:
Depends On:
Blocks: 2250481
TreeView+ depends on / blocked
 
Reported: 2023-12-04 12:42 UTC by Fabio Valentini
Modified: 2023-12-05 22:28 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2023-12-05 22:28:44 UTC
Type: ---
Embargoed:
jistone: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-12-04 12:42:56 UTC
Spec URL: https://decathorpe.fedorapeople.org/rust-serde-untagged.spec
SRPM URL: https://decathorpe.fedorapeople.org/rust-serde-untagged-0.1.1-1.fc39.src.rpm

Description:
Serde `Visitor` implementation for deserializing untagged enums.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-04 12:42:59 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=109890775

Comment 2 Fedora Review Service 2023-12-04 12:47:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6722913
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252746-rust-serde-untagged/fedora-rawhide-x86_64/06722913-rust-serde-untagged/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Josh Stone 2023-12-04 23:29:09 UTC
LGTM!

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (MIT OR Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 4 Fabio Valentini 2023-12-05 10:54:33 UTC
Thank you for the quick review!

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-05 10:55:07 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-serde-untagged

Comment 6 Fedora Update System 2023-12-05 20:54:23 UTC
FEDORA-2023-ff1209077d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-ff1209077d

Comment 7 Fedora Update System 2023-12-05 22:28:44 UTC
FEDORA-2023-ff1209077d has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.