Spec URL: https://github.com/odra/kconfiglib-rpm/blob/master/python3-kconfig.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-38-x86_64/06724530-kconfiglib/kconfiglib-14.1.0-1.fc38.src.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Copr build: https://copr.fedorainfracloud.org/coprs/build/6724579 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/06724579-kconfiglib/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6946790 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/srpm-builds/06946790/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://github.com/odra/kconfiglib-rpm/blob/master/python3-kconfig.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-rawhide-x86_64/06756659-kconfiglib/kconfiglib-14.1.0-1.fc40.src.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Copr build: https://copr.fedorainfracloud.org/coprs/build/6946805 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/06946805-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hey Leonardo Fedora Review fails as the spec file isn't found in the srpm. Possibly due to the inconsistent naming between the package and file. If the package name is kconfiglib, the spec file should be kconfiglib.spec (won't be picked up by the review service otherwise). Otherwise... - The long-form description is too long for rpmlint - Package summary shouldn't end with a period - URL is duplicated in Source rather than using %{url} (doesn't break the package, just better for maintainability) - Files installed to site-packages should lose their shebang - No man pages for any of the installed Check out the changes suggested here: https://github.com/odra/kconfiglib-rpm/pull/1 (lack of man pages not addressed by that PR)
Thanks for the patch but I don't think that package provides any man pages since it's a python library, should it use something else or another mechanism to indicate that there is no manpage?
Trying to figure out some other issue with the spec and forgot to mention it. help2man was suggested to me by code@music, and I'm very pleased with the result. Being used in my own spec here: https://github.com/ppfeister/pkg/blob/master/sherlock/sherlock-project.spec Note L55-61 in %install: ``` install -d '%{buildroot}%{_mandir}/man1' PYTHONPATH='%{buildroot}%{python3_sitelib}' help2man \ --no-info \ --version-string='%{version}' \ --name='%{summary}' \ --output='%{buildroot}%{_mandir}/man1/sherlock.1' \ '%{buildroot}%{_bindir}/sherlock' ``` And L72 in %files: ``` %{_mandir}/man1/sherlock.1* ``` Fairly easily adaptable. For each bin that you want to generate a man page for, swap `sherlock` with the name of the file. The only problem was that you've got a bakers dozen different files being installed that may (or may not) each warrant their own man page -- I'm debating if there's a more 'friendly' way to address it rather than repeating that entire chunk 13 times. Possibly expanding a loop, but that's still not the prettiest. If looped somehow, the 'sed's can be dropped to just one and included in the loop as well...... in theory.
I should include --- help2man needs a new Build Req as well. BuildRequires: help2man as on L21 of my linked example. Can be placed up with your other Requires.
Spec URL: https://github.com/odra/kconfiglib-rpm/blob/master/python3-kconfig.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-rawhide-x86_64/08086374-kconfiglib/kconfiglib-14.1.0-2.fc42.src.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Copr build: https://copr.fedorainfracloud.org/coprs/build/8086386 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/08086386-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8208135 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/08208135-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
@redhat Hey Paul, apologies for the delay, would you be willing to review this package again?
*** Bug 2354337 has been marked as a duplicate of this bug. ***
Can the latest source release available at https://github.com/zephyrproject-rtos/Kconfiglib be used?
The name should also be python-kconfiglib
Need to be able to download spec file from direct link. spec: https://raw.githubusercontent.com/odra/kconfiglib-rpm/refs/heads/master/kconfiglib.spec srpm: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-rawhide-x86_64/08086374-kconfiglib/kconfiglib-14.1.0-2.fc42.src.rpm
Sure, let me update my spec file. Question: the package can be used as both a python library and CLI. Should it still be named "python-kconfiglib"?
kconfiglib is fine as the main name, since python3-kconfiglib is also provided. To avoid building documentation in the install section, please bootstrap the package: https://docs.fedoraproject.org/en-US/packaging-guidelines/#bootstrapping If possible, please also follow the newer Python packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/Python
Spec URL: https://raw.githubusercontent.com/odra/kconfiglib-rpm/refs/heads/master/kconfiglib.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-rawhide-x86_64/08848661-kconfiglib/python3-kconfiglib-14.1.0-3.fc43.noarch.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Spec URL: https://raw.githubusercontent.com/odra/kconfiglib-rpm/refs/heads/master/kconfiglib.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-rawhide-x86_64/08848661-kconfiglib/kconfiglib-14.1.0-3.fc43.src.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Copr build: https://copr.fedorainfracloud.org/coprs/build/8848681 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/08848681-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8848683 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/08848683-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8848682 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/08848682-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello Benson, Could you please give it another review?
MOCK REVIEW: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info/PKG-INFO See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC License", "Unknown or generated", "*No copyright* ISC License". 80 files have unknown license. Detailed output of licensecheck in /home/maestro/dev/review/review- kconfiglib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13, /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info, /usr/lib/python3.13/site- packages/__pycache__ [x]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 76864 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [ ]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-kconfiglib [-]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Spec file according to URL is the same as in SRPM. Note: Spec file as given by url is not the same as in SRPM (see attached diff). See: (this test has no URL) [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: kconfiglib-14.1.0-3.fc43.noarch.rpm python3-kconfiglib-14.1.0-3.fc43.noarch.rpm kconfiglib-14.1.0-3.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp2d7eg37e')] checks: 32, packages: 3 kconfiglib.src: E: spelling-error ('menuconfig', '%description -l en_US menuconfig -> configure') kconfiglib.spec: E: specfile-error error: bad date in %changelog: Tues Apr 01 2025 Leonardo Rossetti <lrossett> - 14.1.0-4 python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/alldefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allmodconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allnoconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allyesconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/defconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/genconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/guiconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/listnewconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/menuconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/oldconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/olddefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/savedefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/setconfig.py 644 /usr/bin/python3 -sP kconfiglib.noarch: E: no-changelogname-tag kconfiglib.src: E: no-changelogname-tag python3-kconfiglib.noarch: E: no-changelogname-tag kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/alldefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allmodconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allnoconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allyesconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/defconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/genconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/guiconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/listnewconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/menuconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/oldconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/olddefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/savedefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/setconfig.1 3 packages and 0 specfiles checked; 18 errors, 13 warnings, 10 filtered, 18 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/alldefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allmodconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allnoconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allyesconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/defconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/genconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/guiconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/listnewconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/menuconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/oldconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/olddefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/savedefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/setconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: no-changelogname-tag kconfiglib.noarch: E: no-changelogname-tag kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/alldefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allmodconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allnoconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allyesconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/defconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/genconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/guiconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/listnewconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/menuconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/oldconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/olddefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/savedefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/setconfig.1 2 packages and 0 specfiles checked; 15 errors, 13 warnings, 6 filtered, 15 badness; has taken 0.1 s Source checksums ---------------- https://github.com/zephyrproject-rtos/Kconfiglib/archive/refs/tags/v14.1.0.tar.gz : CHECKSUM(SHA256) this package : 571c5b6b0a5704fd08d1ec8312ce47438d52bca8d392b8adb81516aa11ae15f6 CHECKSUM(SHA256) upstream package : 571c5b6b0a5704fd08d1ec8312ce47438d52bca8d392b8adb81516aa11ae15f6 Requires -------- kconfiglib (rpmlib, GLIBC filtered): /usr/bin/python3 python3-kconfiglib (rpmlib, GLIBC filtered): python(abi) Provides -------- kconfiglib: kconfiglib python3-kconfiglib: python-kconfiglib python3-kconfiglib python3.13-kconfiglib Diff spec file in url and in SRPM --------------------------------- --- /home/maestro/dev/review/kconfiglib.spec 2025-05-06 08:53:08.638159831 +0530 +++ /home/maestro/dev/review/review-kconfiglib/srpm-unpacked/kconfiglib.spec 2025-04-02 16:00:34.000000000 +0530 @@ -144,3 +144,2 @@ * Mon Dec 04 2023 Leonardo Rossetti <lrossett> - 14.1.0-1 - Initital spec file - Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -n kconfiglib Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: fonts, Haskell, Perl, PHP, Ocaml, R, C/C++, SugarActivity, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Summary: - %{python3_sitelib}/kconfiglib-%{version}-py%{python3_version}.egg-info/PKG-INFO has been listed twice in %files - Fix changelog date: use valid day abbreviation (Tue not Tues) - The script /usr/lib/python3.13/site-packages/alldefconfig.py declares a shebang (#!/usr/bin/python3 -sP) but doesn’t have the executable bit set (chmod +x) - Directories without known owners: /usr/lib/python3.13/site-packages, /usr/lib/python3.13, /usr/lib/python3.13/site-packages/kconfiglib-14.1.0-py3.13.egg-info, /usr/lib/python3.13/site-packages/__pycache__
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info/PKG-INFO See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "ISC License", "Unknown or generated", "*No copyright* ISC License". 80 files have unknown license. Detailed output of licensecheck in /home/fedora-packaging/reviews/python- kconfiglib/2252811-kconfiglib/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages/kconfiglib-14.1.0-py3.13.egg-info, /usr/lib/python3.13/site- packages, /usr/lib/python3.13, /usr/lib/python3.13/site- packages/__pycache__ [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 76864 bytes in 2 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [ ]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-kconfiglib [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kconfiglib-14.1.0-3.fc43.noarch.rpm python3-kconfiglib-14.1.0-3.fc43.noarch.rpm kconfiglib-14.1.0-3.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpizumy11y')] checks: 32, packages: 3 kconfiglib.src: E: spelling-error ('menuconfig', '%description -l en_US menuconfig -> configure') kconfiglib.spec: E: specfile-error error: bad date in %changelog: Tues Apr 01 2025 Leonardo Rossetti <lrossett> - 14.1.0-4 python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/alldefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allmodconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allnoconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allyesconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/defconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/genconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/guiconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/listnewconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/menuconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/oldconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/olddefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/savedefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/setconfig.py 644 /usr/bin/python3 -sP kconfiglib.noarch: E: no-changelogname-tag kconfiglib.src: E: no-changelogname-tag python3-kconfiglib.noarch: E: no-changelogname-tag kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/alldefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allmodconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allnoconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allyesconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/defconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/genconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/guiconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/listnewconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/menuconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/oldconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/olddefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/savedefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/setconfig.1 3 packages and 0 specfiles checked; 18 errors, 13 warnings, 10 filtered, 18 badness; has taken 0.6 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/alldefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allmodconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allnoconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/allyesconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/defconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/genconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/guiconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/listnewconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/menuconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/oldconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/olddefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/savedefconfig.py 644 /usr/bin/python3 -sP python3-kconfiglib.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/setconfig.py 644 /usr/bin/python3 -sP kconfiglib.noarch: E: no-changelogname-tag python3-kconfiglib.noarch: E: no-changelogname-tag kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/alldefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allmodconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allnoconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/allyesconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/defconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/genconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/guiconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/listnewconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/menuconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/oldconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/olddefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/savedefconfig.1 kconfiglib.noarch: W: manpage-not-compressed gz /usr/share/man/man1/setconfig.1 2 packages and 0 specfiles checked; 15 errors, 13 warnings, 6 filtered, 15 badness; has taken 0.1 s Source checksums ---------------- https://github.com/zephyrproject-rtos/Kconfiglib/archive/refs/tags/v14.1.0.tar.gz : CHECKSUM(SHA256) this package : 571c5b6b0a5704fd08d1ec8312ce47438d52bca8d392b8adb81516aa11ae15f6 CHECKSUM(SHA256) upstream package : 571c5b6b0a5704fd08d1ec8312ce47438d52bca8d392b8adb81516aa11ae15f6 Requires -------- kconfiglib (rpmlib, GLIBC filtered): /usr/bin/python3 python3-kconfiglib (rpmlib, GLIBC filtered): python(abi) Provides -------- kconfiglib: kconfiglib python3-kconfiglib: python-kconfiglib python3-kconfiglib python3.13-kconfiglib Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2252811 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: PHP, C/C++, Ocaml, Java, Haskell, SugarActivity, Perl, fonts, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) to ensure directories are owned, please add in the files listing: %dir %{python3_sitelib}/kconfiglib-%{version}-py%{python3_version}.egg-info/ other unowned directories are errors in fedora-review tool b) for an example of using bootstrap see: https://src.fedoraproject.org/rpms/python-androguard/blob/rawhide/f/python-androguard.spec c) please change Tues Apr 01 2025 Leonardo Rossetti <lrossett> - 14.1.0-4 to Tue Apr 01 2025 Leonardo Rossetti <lrossett> - 14.1.0-4
Spec URL: https://github.com/odra/kconfiglib-rpm/blob/master/python3-kconfig.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/lrossett/yocto-dev-tools/fedora-eln-x86_64/09072724-kconfiglib/kconfiglib-14.1.0-5.eln148.src.rpm Description: Kconfig implementation in Python. Fedora Account System Username: lrossett
Copr build: https://copr.fedorainfracloud.org/coprs/build/9072823 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/09072823-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Created attachment 2091119 [details] The .spec file difference from Copr build 9072823 to 9072833
Copr build: https://copr.fedorainfracloud.org/coprs/build/9072833 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2252811-kconfiglib/fedora-rawhide-x86_64/09072833-kconfiglib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec file updated.