Bug 2253292 - Review Request: libkdepim - Library for common kdepim apps
Summary: Review Request: libkdepim - Library for common kdepim apps
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://invent.kde.org/pim/%{name}
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-06 17:04 UTC by Steve Cossette
Modified: 2023-12-06 20:44 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-06 20:44:23 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Steve Cossette 2023-12-06 17:04:01 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/libkdepim/libkdepim.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/libkdepim/libkdepim-24.01.80-1.fc39.src.rpm

Description:
Library for common kdepim apps.


Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=109983181

Fedora Account System Username: farchord

Comment 1 Yaakov Selkowitz 2023-12-06 17:07:33 UTC
FWIW we shouldn't need ancient obsoletes/provides anymore, there is no direct upgrade path from any version that had them to F40/EL10:

Obsoletes:      kdepim-libs < 7:16.04.0
Conflicts:      kdepim-libs < 7:16.04.0
# kdepimwidgets designer plugin moved here
Conflicts:      kdepim-common < 16.04.0
# kcm_ldap moved here
Conflicts:      kaddressbook < 16.04.0

Comment 2 Fedora Review Service 2023-12-06 17:15:33 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6729373
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253292-libkdepim/fedora-rawhide-x86_64/06729373-libkdepim/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-12-06 19:57:49 UTC
Review notes:

* Package follows Fedora Packaging Guidelines
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

When you import this, please drop the obsolete stanzas pointed out in comment 1.

PACKAGE APPROVED.

Comment 4 Steve Cossette 2023-12-06 20:36:42 UTC
Thank you for the review, Neal

Comment 5 Fedora Admin user for bugzilla script actions 2023-12-06 20:39:09 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/libkdepim


Note You need to log in before you can comment on or make changes to this bug.