Spec URL: https://jjames.fedorapeople.org/zimpl/zimpl.spec SRPM URL: https://jjames.fedorapeople.org/zimpl/zimpl-3.5.3-1.fc40.src.rpm Fedora Account System Username: jjames Description: Zimpl is a little language to translate the mathematical model of a problem into a linear or nonlinear (mixed-) integer mathematical program expressed in .lp or .mps file format which can be read and (hopefully) solved by a LP or MIP solver. This package is part of an effort to add the SoPlex and SCIP solvers to Fedora. The entire collection of packages is available in a COPR: https://copr.fedorainfracloud.org/coprs/jjames/SCIP/.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6729878 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253358-zimpl/fedora-rawhide-x86_64/06729878-zimpl/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Will take this as a second package in the review swap (going numerically in terms of bug numbers :P).
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Notes: ====== MUST: - Errors in the License breakdown: 1. It's LGPL-2.0-or-later for mmlparse2.y and mmlscan.l not 2.1. 2. mmlparse2.h is in libzimpl-devel and mmlparse2.c is compiled in zimpl, so their license should be specified in the LICENSE field as well as a quick license breakdown comment. Otherwise, the License breakdown is magnificent! I'm impressed at how you even specified the PDF font licenses! Where is the source for that, btw? ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "GNU Lesser General Public License v3.0 or later", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License", "GNU General Public License v2.0 or later", "GNU Lesser General Public License", "MIT License", "BSD 3-Clause License", "*No copyright* Do What The Fuck You Want To Public License, Version 2", "Standard ML of New Jersey License", "Eclipse Public License 1.0", "zlib License", "GNU Lesser General Public License v2.1 or later [obsolete FSF postal address (Temple Place)]", "GNU General Public License v3.0 or later", "GNU Library General Public License v2 or later", "GNU Lesser General Public License v3.0 or later [generated file]", "Boost Software License 1.0", "BSD 2-Clause License", "*No copyright* Boost Software License 1.0", "*No copyright* MIT License". 1973 files have unknown license. Detailed output of licensecheck in /var/home/lyes/Documents/reviews/2253358-zimpl/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Note: Great License breakdown ! [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 439998 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: Everything is LGPLv3 compatible and it is hard to contact upstream, so it is fine. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libzimpl [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. Note: upstream uses mails. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [?]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: zimpl-3.5.3-1.fc40.x86_64.rpm libzimpl-3.5.3-1.fc40.x86_64.rpm libzimpl-devel-3.5.3-1.fc40.x86_64.rpm zimpl-debuginfo-3.5.3-1.fc40.x86_64.rpm zimpl-debugsource-3.5.3-1.fc40.x86_64.rpm zimpl-3.5.3-1.fc40.src.rpm ============================================================================== rpmlint session starts ============================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmplov6cpla')] checks: 32, packages: 6 libzimpl.x86_64: E: spelling-error ('Zuse', 'Summary(en_US) Zuse -> Use, Zeus, Ruse') libzimpl.x86_64: E: spelling-error ('lp', '%description -l en_US lp -> LP, pl, lo') libzimpl.x86_64: E: spelling-error ('mps', '%description -l en_US mps -> mos, mp, ms') zimpl.src: E: spelling-error ('Zuse', 'Summary(en_US) Zuse -> Use, Zeus, Ruse') zimpl.src: E: spelling-error ('lp', '%description -l en_US lp -> LP, pl, lo') zimpl.src: E: spelling-error ('mps', '%description -l en_US mps -> mos, mp, ms') zimpl.x86_64: E: spelling-error ('Zuse', 'Summary(en_US) Zuse -> Use, Zeus, Ruse') zimpl.x86_64: E: spelling-error ('lp', '%description -l en_US lp -> LP, pl, lo') zimpl.x86_64: E: spelling-error ('mps', '%description -l en_US mps -> mos, mp, ms') zimpl.x86_64: W: package-with-huge-docs 86% zimpl.spec:86: W: deprecated-grep ['fgrep'] ======================================== 6 packages and 0 specfiles checked; 9 errors, 2 warnings, 44 filtered, 9 badness; has taken 0.9 s ========================================= Rpmlint (debuginfo) ------------------- Checking: zimpl-debuginfo-3.5.3-1.fc40.x86_64.rpm ============================================================================== rpmlint session starts ============================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp51cce6da')] checks: 32, packages: 1 ======================================== 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 10 filtered, 0 badness; has taken 0.1 s ========================================= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 5 libzimpl.x86_64: E: spelling-error ('Zuse', 'Summary(en_US) Zuse -> Use, Zeus, Ruse') libzimpl.x86_64: E: spelling-error ('lp', '%description -l en_US lp -> LP, pl, lo') libzimpl.x86_64: E: spelling-error ('mps', '%description -l en_US mps -> mos, mp, ms') zimpl.x86_64: E: spelling-error ('Zuse', 'Summary(en_US) Zuse -> Use, Zeus, Ruse') zimpl.x86_64: E: spelling-error ('lp', '%description -l en_US lp -> LP, pl, lo') zimpl.x86_64: E: spelling-error ('mps', '%description -l en_US mps -> mos, mp, ms') zimpl.x86_64: W: package-with-huge-docs 86% 5 packages and 0 specfiles checked; 6 errors, 1 warnings, 40 filtered, 6 badness; has taken 0.8 s Source checksums ---------------- https://scipopt.org/download/release/scipoptsuite-8.0.4.tgz : CHECKSUM(SHA256) this package : be4f978be7f8f97371ddcdac7a60af69a4fea5f975090fe35f1ae4308db692d3 CHECKSUM(SHA256) upstream package : be4f978be7f8f97371ddcdac7a60af69a4fea5f975090fe35f1ae4308db692d3 Requires -------- zimpl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgmp.so.10()(64bit) libzimpl(x86-64) libzimpl.so.0()(64bit) rtld(GNU_HASH) libzimpl (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgmp.so.10()(64bit) libm.so.6()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) libzimpl-devel (rpmlib, GLIBC filtered): cmake-filesystem(x86-64) libzimpl(x86-64) libzimpl.so.0()(64bit) zimpl(x86-64) zimpl-debuginfo (rpmlib, GLIBC filtered): zimpl-debugsource (rpmlib, GLIBC filtered): Provides -------- zimpl: zimpl zimpl(x86-64) libzimpl: libzimpl libzimpl(x86-64) libzimpl.so.0()(64bit) libzimpl-devel: cmake(zimpl) libzimpl-devel libzimpl-devel(x86-64) zimpl-debuginfo: debuginfo(build-id) zimpl-debuginfo zimpl-debuginfo(x86-64) zimpl-debugsource: zimpl-debugsource zimpl-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2253358 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Perl, R, Java, PHP, Python, Haskell, fonts, Ocaml, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Just woke up, and figured out that this > and mmlparse2.c is compiled in zimpl was wrong. I was tired yesterday xD. The zimpl binary only links to libzimpl which compiles with mmlparse2, and thanks to the exception, it doesn't inherit GPLv2. Only libzimpl-devel needs the extra license.
Thank you, Lyes. I have fixed the License tags, I think. The URLs are the same as before. As for the license information, I went through various documentation generators awhile ago and made this web page to help me figure out the licensing: https://jamezone.org/pleasure/software/Fedora/license/.
Wow ! Thank you for the source ! That's a very useful link ! Anyway, everything seems good to me, package approved !
Thank you for the review, and happy new year!
The Pagure repository was created at https://src.fedoraproject.org/rpms/zimpl
Version 3.5.3 has been built in Rawhide.