Bug 225341 - (pear-CodeSniffer) Review Request: php-pear-PHP-CodeSniffer - PHP coding standards enforcement tool
Review Request: php-pear-PHP-CodeSniffer - PHP coding standards enforcement tool
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Christopher Stone
Fedora Package Reviews List
:
Depends On:
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-01-29 18:16 EST by Konstantin Ryabitsev
Modified: 2014-10-13 18:56 EDT (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-13 21:09:54 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
kevin: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Konstantin Ryabitsev 2007-01-29 18:16:47 EST
Spec URL: http://blues.mcgill.ca/~icon/fe/php-pear-PHP_CodeSniffer.spec
SRPM URL: http://blues.mcgill.ca/~icon/fe/php-pear-PHP_CodeSniffer-0.3.0-1.fc6.src.rpm
Description:
PHP_CodeSniffer provides functionality to verify that code conforms to
certain standards, such as PEAR, or user-defined.
Comment 1 Christopher Stone 2007-01-29 19:56:36 EST
==== REVIEW CHECKLIST ====
- rpmlint output clean
X package is not named according to package naming guidelines
- spec file name matches %{name}
- package meets packaging guideliens
- licensed with open source compatible license
- license in spec matches actual license
- license file included in %doc
- spec written in American english
- spec file legible
- sources match upstream
9b13c0cad263a1e7044b8135b37a1c93  PHP_CodeSniffer-0.3.0.tgz
- successfully compiles and builds on FC-6 x86_64
- all build dependencies listed in BR
- no locales
- no shared libraries
- not relocatable
X package does not own all directories it creates
- no duplicates in %files
- file permissions set properly
- contains proper %clean
- macro usage is consistent
- contains code
- no large documentation
- %doc does not affect runtime
- no header files or static libraries
- no pkgconfig files
- no library files with suffix
- no need for devel subpackage
- no libtool archives
- not a GUI application
- does not own files or directories owned by other packages


==== MUST FIX ====
- Package must meet packaging naming guidelines, rename package to:
  php-pear-PHP-CodeSniffer
- Rename %{name} accordingly
- Package must own all directories it creates:
  change %{pear_phpdir}/PHP/* to %{pear_phpdir}/PHP in %files

==== SHOULD FIX ====
- URL should not contain a macro as it is copy&pasted from spec file by
maintainers on a regular basis
- Add versioned Requires: php > 5.1.0
Comment 3 Christopher Stone 2007-01-29 20:17:51 EST
All MUST FIX items fixed.

APPROVED
Comment 4 Christopher Stone 2007-03-13 21:09:54 EDT
Looks like this was build okay, I'm closing this bug.  Please close your bugs
after package is built.
Comment 5 Konstantin Ryabitsev 2007-06-11 11:25:16 EDT
Package Change Request
======================
Package Name: php-pear-PHP-CodeSniffer
New Branches: EL-5
Comment 6 Kevin Fenzi 2007-06-11 12:12:43 EDT
branch done.
Comment 7 Remi Collet 2014-10-09 09:27:26 EDT
Package Change Request
======================
Package Name: php-pear-PHP-CodeSniffer
New Branches: epel7
Owners: remi
Comment 8 Kevin Fenzi 2014-10-13 18:56:06 EDT
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.