Spec URL: https://principis.fedorapeople.org/libayatana-indicator.spec SRPM URL: https://principis.fedorapeople.org/libayatana-indicator-0.9.4-1.fc39.src.rpm Description: The Ayatana Indicators library contains information to build indicators to go into modern desktops' indicator applets. Fedora Account System Username: principis
Copr build: https://copr.fedorainfracloud.org/coprs/build/6732795 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253580-libayatana-indicator/fedora-rawhide-x86_64/06732795-libayatana-indicator/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Added tests, but disabled by default due to 1 test failing: https://github.com/AyatanaIndicators/libayatana-indicator/issues/73 Spec URL: https://principis.fedorapeople.org/libayatana-indicator.spec SRPM URL: https://principis.fedorapeople.org/libayatana-indicator-0.9.4-1.fc39.src.rpm
Copr build: https://copr.fedorainfracloud.org/coprs/build/7057696 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253580-libayatana-indicator/fedora-rawhide-x86_64/07057696-libayatana-indicator/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I reviewed libayatana-indicator.spec is also good and it doesn't override the old libappindicator. We just need to check if it builds with libayatana-ido3-0.4 and dbus-test-runner to approve for that we need build dbus-test-runner on rawhide and enable tests in this package
Tests work in mock, so re-enabled them. Spec URL: https://principis.fedorapeople.org/libayatana-indicator.spec SRPM URL: https://principis.fedorapeople.org/libayatana-indicator-0.9.4-1.fc39.src.rpm
(In reply to Arthur Bols from comment #5) > Tests work in mock, so re-enabled them. > > > Spec URL: https://principis.fedorapeople.org/libayatana-indicator.spec > SRPM URL: > https://principis.fedorapeople.org/libayatana-indicator-0.9.4-1.fc39.src.rpm where is mock build ? can you enable in copr settings "[] Run fedora-review tool for packages in this project" fedora-review-service is down since yesterday ...
(In reply to Sergio Basto from comment #6) > where is mock build ? can you enable in copr settings "[] Run fedora-review > tool for packages in this project" > > fedora-review-service is down since yesterday ... I rebuild it in copr with fedora-review option enabled: https://copr.fedorainfracloud.org/coprs/principis/ayatana-indicator-libs/build/7059245/ . fedora-review seems broken on rawhide, but you can use the f39 one.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [ ]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [ ]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GNU General Public License, Version 3". 49 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/libayatana-indicator/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6340 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libayatana-indicator-gtk2 , libayatana-indicator-gtk3 , libayatana- indicator-gtk2-devel , libayatana-indicator-gtk3-devel , libayatana- indicator-tools-gtk3 [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [ ]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _vpath_builddir build- gtk3, %define _vpath_builddir build-gtk2, %define _vpath_builddir build-gtk3, %define _vpath_builddir build-gtk2, %define _vpath_builddir build-gtk3, %define _vpath_builddir build-gtk2 [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: libayatana-indicator-gtk2-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-gtk3-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-gtk2-devel-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-gtk3-devel-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-tools-gtk3-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-debuginfo-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-debugsource-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-0.9.4-1.fc39.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp8wa5tykk')] checks: 32, packages: 8 libayatana-indicator-tools-gtk3.x86_64: W: unstripped-binary-or-object /usr/libexec/libayatana-indicator/ayatana-indicator-loader3 libayatana-indicator-tools-gtk3.x86_64: E: shlib-policy-missing-lib libayatana-indicator-gtk2-devel.x86_64: E: description-line-too-long The libayatana-indicator-gtk2-devel package contains libraries and header files for libayatana-indicator-gtk3-devel.x86_64: E: description-line-too-long The libayatana-indicator-gtk3-devel package contains libraries and header files for 8 packages and 0 specfiles checked; 3 errors, 1 warnings, 57 filtered, 3 badness; has taken 0.9 s Rpmlint (debuginfo) ------------------- Checking: libayatana-indicator-debuginfo-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-gtk3-debuginfo-0.9.4-1.fc39.x86_64.rpm libayatana-indicator-gtk2-debuginfo-0.9.4-1.fc39.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpsoynaa64')] checks: 32, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 17 filtered, 0 badness; has taken 0.4 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "libayatana-indicator-gtk3-debuginfo". (none): E: there is no installed rpm "libayatana-indicator-tools-gtk3". (none): E: there is no installed rpm "libayatana-indicator-debugsource". (none): E: there is no installed rpm "libayatana-indicator-gtk3". (none): E: there is no installed rpm "libayatana-indicator-gtk2". (none): E: there is no installed rpm "libayatana-indicator-gtk2-debuginfo". (none): E: there is no installed rpm "libayatana-indicator-gtk3-devel". (none): E: there is no installed rpm "libayatana-indicator-debuginfo". (none): E: there is no installed rpm "libayatana-indicator-gtk2-devel". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://github.com/AyatanaIndicators/libayatana-indicator/archive/0.9.4/libayatana-indicator-0.9.4.tar.gz : CHECKSUM(SHA256) this package : a18d3c682e29afd77db24366f8475b26bda22b0e16ff569a2ec71cd6eb4eac95 CHECKSUM(SHA256) upstream package : a18d3c682e29afd77db24366f8475b26bda22b0e16ff569a2ec71cd6eb4eac95 Requires -------- libayatana-indicator-gtk2 (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-x11-2.0.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) libayatana-indicator-gtk3 (rpmlib, GLIBC filtered): libayatana-ido3-0.4.so.0()(64bit) libc.so.6()(64bit) libgdk-3.so.0()(64bit) libgdk_pixbuf-2.0.so.0()(64bit) libgio-2.0.so.0()(64bit) libglib-2.0.so.0()(64bit) libgmodule-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libgtk-3.so.0()(64bit) libm.so.6()(64bit) rtld(GNU_HASH) libayatana-indicator-gtk2-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libayatana-indicator-gtk2(x86-64) libayatana-indicator.so.7()(64bit) pkgconfig(gtk+-2.0) libayatana-indicator-gtk3-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libayatana-indicator-gtk3(x86-64) libayatana-indicator3.so.7()(64bit) pkgconfig(gtk+-3.0) pkgconfig(libayatana-ido3-0.4) libayatana-indicator-tools-gtk3 (rpmlib, GLIBC filtered): libayatana-indicator-gtk3(x86-64) libayatana-indicator-debuginfo (rpmlib, GLIBC filtered): libayatana-indicator-debugsource (rpmlib, GLIBC filtered): Provides -------- libayatana-indicator-gtk2: libayatana-indicator-gtk2 libayatana-indicator-gtk2(x86-64) libayatana-indicator.so.7()(64bit) libayatana-indicator-gtk3: libayatana-indicator-gtk3 libayatana-indicator-gtk3(x86-64) libayatana-indicator3.so.7()(64bit) libayatana-indicator-gtk2-devel: libayatana-indicator-gtk2-devel libayatana-indicator-gtk2-devel(x86-64) pkgconfig(ayatana-indicator-0.4) libayatana-indicator-gtk3-devel: libayatana-indicator-gtk3-devel libayatana-indicator-gtk3-devel(x86-64) pkgconfig(ayatana-indicator3-0.4) libayatana-indicator-tools-gtk3: libayatana-indicator-tools-gtk3 libayatana-indicator-tools-gtk3(x86-64) libayatana-indicator-debuginfo: libayatana-indicator-debuginfo libayatana-indicator-debuginfo(x86-64) libayatana-indicator-debugsource: libayatana-indicator-debugsource libayatana-indicator-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name libayatana-indicator --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-39-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: fonts, SugarActivity, Ocaml, Haskell, Java, PHP, Python, R, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Nothing to point , it builds well with tests enabled Package APPROVED
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/libayatana-indicator
FEDORA-2024-80f9f5cf80 (libayatana-indicator-0.9.4-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-80f9f5cf80
FEDORA-2024-80f9f5cf80 (libayatana-indicator-0.9.4-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-ec91cb74e2 (libayatana-indicator-0.9.4-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-ec91cb74e2
FEDORA-2024-ec91cb74e2 (libayatana-indicator-0.9.4-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-00f0a54533 (libayatana-indicator-0.9.4-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-00f0a54533