Bug 225366 - Review Request: perl-Module-Depends - Identify the dependencies of a distribution
Summary: Review Request: perl-Module-Depends - Identify the dependencies of a distribu...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Parag AN(पराग)
QA Contact: Fedora Package Reviews List
URL:
Whiteboard:
Depends On:
Blocks: FE-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2007-01-30 06:02 UTC by Ian Burrell
Modified: 2008-06-06 19:02 UTC (History)
0 users

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2007-02-13 21:33:00 UTC
Type: ---
Embargoed:
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Ian Burrell 2007-01-30 06:02:22 UTC
Spec URL: http://znark.com/fedora/perl-Module-Depends.spec
SRPM URL: http://znark.com/fedora/perl-Module-Depends-0.10-2.src.rpm
Description: Module::Depends extracts module dependencies from an unpacked
distribution tree.

Comment 1 Parag AN(पराग) 2007-02-09 05:31:49 UTC
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url             
a5751f458e410217ba39f7f32fa8899a  Module-Depends-0.10.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Provides: perl(Module::Depends) = 0.10 perl(Module::Depends::Intrusive)
perl(Module::Depends::Intrusive::Fake::Module::Build)
+ make test
t/depends....ok
All tests successful.
Files=1, Tests=16,  1 wallclock secs ( 0.30 cusr +  0.04 csys =  0.34 CPU)

APPROVED.


Comment 2 Ian Burrell 2007-02-13 21:33:00 UTC
Built for FC-5, FC-6, devel.

Comment 3 Ian Burrell 2008-06-06 18:00:30 UTC
Package Change Request
======================
Package Name: perl-Module-Depends
New Branches: EL-4 EL-5


Comment 4 Kevin Fenzi 2008-06-06 19:02:37 UTC
cvs done.


Note You need to log in before you can comment on or make changes to this bug.