Spec URL: http://znark.com/fedora/perl-Path-Class.spec SRPM URL: http://znark.com/fedora/perl-Path-Class-0.16-1.src.rpm Description: Path::Class is a module for manipulation of file and directory specifications (strings describing their locations, like '/home/ken/foo.txt' or 'C:\Windows\Foo.txt') in a cross-platform manner. It supports pretty much every platform Perl runs on, including Unix, Windows, Mac, VMS, Epoc, Cygwin, OS/2, and NetWare. It is required for SVK 2.0.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. - URL is not working. + source files match when used as upstream url http://search.cpan.org/CPAN/authors/id/K/KW/KWILLIAMS/Path-Class-0.16.tar.gz 2416d2f5ed1a8a98525baea5c25e1c Path-Class-0.16.tar.gz - Change Source URL. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Dose owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Provides: perl(Path::Class) = 0.16 perl(Path::Class::Dir) perl(Path::Class::Entity) perl(Path::Class::File) + make test t/01-basic.........ok t/02-foreign.......# Test 28 got: "dir/subdir" (t/02-foreign.t at line 68 *TODO*) # Expected: "/dir/subdir" # t/02-foreign.t line 68 is: ok $dir->as_foreign('Unix'), '/dir/subdir'; # Test 29 got: "" (t/02-foreign.t at line 69 *TODO*) # Expected: "1" # t/02-foreign.t line 69 is: ok $dir->as_foreign('Unix')->is_absolute, 1; ok 2/29 skipped: Can't test VMS code on other platforms t/03-filesystem....ok All tests successful, 2 subtests skipped. Files=3, Tests=158, 1 wallclock secs ( 0.27 cusr + 0.07 csys = 0.34 CPU) APPROVED. Change Source URL.
Built for FC-5, FC-6, devel.
Package Change Request ====================== Package Name: perl-Path-Class New Branches: EL-4 EL-5
cvs done.