This service will be undergoing maintenance at 00:00 UTC, 2016-08-01. It is expected to last about 1 hours
Bug 225368 - Review Request: ack - Grep-like text finder
Review Request: ack - Grep-like text finder
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Parag AN(पराग)
Fedora Package Reviews List
:
Depends On: 225365
Blocks: FE-ACCEPT
  Show dependency treegraph
 
Reported: 2007-01-30 01:06 EST by Ian Burrell
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-02-15 18:50:29 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Ian Burrell 2007-01-30 01:06:58 EST
Spec URL: http://znark.com/fedora/ack.spec
SRPM URL: http://znark.com/fedora/ack-1.56-2.src.rpm
Description: Ack is designed as a replacement for grep.
Comment 1 Parag AN(पराग) 2007-02-09 01:08:58 EST
any reason for not naming this package's name starting with perl- ?
Comment 2 Parag AN(पराग) 2007-02-09 01:09:34 EST
Source URL not working. check that.
Comment 3 Ian Burrell 2007-02-10 23:01:35 EST
I chose to use "ack" as the package name because it is primarily an application.
 Also, the other choices were "perl-ack" looks like a pragma, or "perl-App-Ack"
which is non-standard and hard to find. 

Fixed Source URL.

Spec URL: http://znark.com/fedora/ack.spec
SRPM URL: http://znark.com/fedora/ack-1.56-3.src.rpm
Comment 4 Parag AN(पराग) 2007-02-11 23:30:14 EST
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
d2c8750f35ae8be79956958e2b653e32  ack-1.56.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Dose owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ Provides: perl(App::Ack) = 1.56

APPROVED.
Comment 5 Michael Schwendt 2007-02-12 09:46:34 EST
> Requires:       perl(File::Next) >= 0.38

That one is automatically set by rpmbuild already, isn't it?

> %setup -q -n ack-%{version}

-n %{name}-%{version} is automatic already

> make %{?_smp_mflags}

SMP make flags in a noarch build are superfluous.
Comment 6 Michael Schwendt 2007-02-12 09:54:23 EST
How about getting

%check
make test

included in the package?
Comment 7 Ville Skyttä 2007-02-12 11:41:40 EST
(In reply to comment #5)

> SMP make flags in a noarch build are superfluous.

Not necessarily, they don't have anything to do with archs per se.  Granted,
noarch packages benefit from parallel builds much less often than eg. ones that
invoke a C compiler.
Comment 8 Michael Schwendt 2007-02-12 12:53:29 EST
Right, but with a 34 KB noarch package and no costly computations
during %build, there is no gain to expect on a MP system. The risk
is greater than the potential benefit.
Comment 9 Ian Burrell 2007-02-12 14:12:28 EST
I left out the %check block because the tests fail when run without a terminal.
 This is a bug in the tests in that they assume that they are run from a
terminal.   The tests pass when run normaly.

I entered a bug upstream to fix the problem.
http://rt.cpan.org/Public/Bug/Display.html?id=24670
Comment 10 Ian Burrell 2007-02-12 14:19:58 EST
>> Requires:       perl(File::Next) >= 0.38

> That one is automatically set by rpmbuild already, isn't it?

I removed the manual one.

>> %setup -q -n ack-%{version}

> -n %{name}-%{version} is automatic already

That was an artifact of renaming the package.

Spec URL: http://znark.com/fedora/ack.spec
SRPM URL: http://znark.com/fedora/ack-1.56-4.src.rpm
Comment 11 Parag AN(पराग) 2007-02-12 23:32:57 EST
I rechecked the new release in mock.
It built fine.
rpmlint is silent.
So new package is ok.
Comment 12 Parag AN(पराग) 2007-02-12 23:37:01 EST
Thanks Michael for your comments.
Comment 13 Ian Burrell 2007-08-29 14:53:55 EDT
Package Change Request
======================
Package Name: ack
New Branches: EL-4 EL-5

Note You need to log in before you can comment on or make changes to this bug.