Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent-0.2.0-1.fc40.src.rpm Description: Event collector agent for crypto-auditing project. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6735742 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06735742-rust-crypto-auditing-agent/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Drive-by comment from Rust packaging point of view: > # Upstream license specification: GPL-3.0-or-later > # > # The build dependencies have the following licenses: > # > # (MIT OR Apache-2.0) AND Unicode-DFS-2016 > # Apache-2.0 > # Apache-2.0 OR MIT > # BSD-2-Clause > # BSD-3-Clause OR MIT OR Apache-2.0 > # GPL-3.0-or-later > # LGPL-2.1-only OR BSD-2-Clause > # MIT > # MIT OR Apache-2.0 > # Unlicense OR MIT > # > License: GPL-3.0-or-later > # LICENSE.dependencies contains a full license breakdown This is not correct - the license tag must reflect *all* of the listed licenses, i.e. License: GPL-3.0-or-later AND Apache-2.0 AND BSD-2-Clause AND MIT AND Unicode-DFS-2016 AND (Apache-2.0 OR MIT) AND (BSD-3-Clause OR MIT OR Apache-2.0) AND (LGPL-2.1-only OR BSD-2-Clause) AND (Unlicense OR MIT) c.f. https://docs.fedoraproject.org/en-US/legal/license-field/#_rust_packages
Thanks for the suggestion; fixed the License field: Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent-0.2.1-1.fc40.src.rpm [fedora-review-service-build]
Created attachment 2003930 [details] The .spec file difference from Copr build 6735742 to 6743851
Copr build: https://copr.fedorainfracloud.org/coprs/build/6743851 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06743851-rust-crypto-auditing-agent/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-agent/rust-crypto-auditing-agent-0.2.1-1.fc40.src.rpm [fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/6745144 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06745144-rust-crypto-auditing-agent/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6747002 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06747002-rust-crypto-auditing-agent/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6749219 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06749219-rust-crypto-auditing-agent/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6750957 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253719-rust-crypto-auditing-agent/fedora-rawhide-x86_64/06750957-rust-crypto-auditing-agent/fedora-review/review.txt Found issues: - No gcc, gcc-c++ or clang found in BuildRequires Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ ===== MUST items ===== C/C++: [?]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [?]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: systemd_post is invoked in %post, systemd_preun in %preun, and systemd_postun in %postun for Systemd service files. Note: Systemd service file(s) in crypto-auditing-agent [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 8676 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in crypto- auditing-agent [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [!]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua:, %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: crypto-auditing-agent-0.2.1-1.fc40.x86_64.rpm rust-crypto-auditing-agent-debugsource-0.2.1-1.fc40.x86_64.rpm rust-crypto-auditing-agent-0.2.1-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptlh5r6f9')] checks: 31, packages: 3 crypto-auditing-agent.x86_64: W: non-standard-uid /var/log/crypto-auditing crypto-auditing crypto-auditing-agent.x86_64: W: non-standard-gid /var/log/crypto-auditing crypto-auditing crypto-auditing-agent.x86_64: W: no-manual-page-for-binary crypto-auditing-agent rust-crypto-auditing-agent.spec:37: W: mixed-use-of-spaces-and-tabs (spaces: line 27, tab: line 37) crypto-auditing-agent.x86_64: W: log-files-without-logrotate ['/var/log/crypto-auditing'] 3 packages and 0 specfiles checked; 0 errors, 5 warnings, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "crypto-auditing-agent". (none): E: there is no installed rpm "rust-crypto-auditing-agent-debugsource". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/crypto-auditing-agent/0.2.1/download#/crypto-auditing-agent-0.2.1.crate : CHECKSUM(SHA256) this package : 585580691e61e6940ba75561a00c8de67bebf958339379e4ec573cd70e55551f CHECKSUM(SHA256) upstream package : 585580691e61e6940ba75561a00c8de67bebf958339379e4ec573cd70e55551f Requires -------- crypto-auditing-agent (rpmlib, GLIBC filtered): /bin/sh config(crypto-auditing-agent) ld-linux-x86-64.so.2()(64bit) libbpf.so.1()(64bit) libbpf.so.1(LIBBPF_0.0.1)(64bit) libbpf.so.1(LIBBPF_0.0.4)(64bit) libbpf.so.1(LIBBPF_0.0.7)(64bit) libbpf.so.1(LIBBPF_0.1.0)(64bit) libbpf.so.1(LIBBPF_0.2.0)(64bit) libbpf.so.1(LIBBPF_0.6.0)(64bit) libbpf.so.1(LIBBPF_0.8.0)(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3)(64bit) libgcc_s.so.1(GCC_4.2.0)(64bit) libm.so.6()(64bit) libssl.so.3()(64bit) libssl.so.3(OPENSSL_3.0.0)(64bit) rtld(GNU_HASH) rust-crypto-auditing-agent-debugsource (rpmlib, GLIBC filtered): Provides -------- crypto-auditing-agent: config(crypto-auditing-agent) crypto-auditing-agent crypto-auditing-agent(x86-64) group(crypto-auditing) user(crypto-auditing) rust-crypto-auditing-agent-debugsource: rust-crypto-auditing-agent-debugsource rust-crypto-auditing-agent-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name rust-crypto-auditing-agent --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Java, Haskell, R, PHP, Ocaml, Python, Perl, SugarActivity, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH gpgverify is not used and %global is used instead of the %define as per guidelines. Everything else looks good. Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto-auditing-agent
Thank you for the review! The package has been imported and built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-3d6042456c