Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client-0.2.0-1.fc40.src.rpm Description: Event broker client for crypto-auditing project. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6735831 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253723-rust-crypto-auditing-client/fedora-rawhide-x86_64/06735831-rust-crypto-auditing-client/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client-0.2.1-1.fc40.src.rpm [fedora-review-service-build]
Created attachment 2004212 [details] The .spec file difference from Copr build 6735831 to 6751002
Copr build: https://copr.fedorainfracloud.org/coprs/build/6751002 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253723-rust-crypto-auditing-client/fedora-rawhide-x86_64/06751002-rust-crypto-auditing-client/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> Requires: crypto-auditing-agent This is not attached to any package, since there is no binary package named "rust-crypto-auditing-client" being built. Move this under the "crypto-auditing-client" subpackage for it to have the intended effect. > License: GPL-3.0-or-later AND (MIT OR Apache-2.0) AND Unicode-DFS-2016 AND (Apache-2.0 OR BSL-1.0) AND (Apache-2.0 OR MIT) AND MIT AND (MIT OR Apache-2.0) AND (Unlicense OR MIT) There are three occurrences of "(MIT OR Apache-2.0)" here, please drop all but one of them (where "(MIT OR Apache-2.0)" and "(Apache-2.0 OR MIT)" are equivalent). > %config(noreplace) %{_sysconfdir}/crypto-auditing/client.conf This leaves the directory at "%{_sysconfdir}/crypto-auditing/" unowned, add this to fix it: %dir %{_sysconfdir}/crypto-auditing/ Other than those three minor issues, looks good to me.
Thank you for the review. Those issues should be addressed in the new spec. Spec URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client.spec SRPM URL: https://ueno.fedorapeople.org/rust-crypto-auditing-client/rust-crypto-auditing-client-0.2.1-1.fc40.src.rpm [fedora-review-service-build]
Created attachment 2004302 [details] The .spec file difference from Copr build 6751002 to 6757433
Copr build: https://copr.fedorainfracloud.org/coprs/build/6757433 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2253723-rust-crypto-auditing-client/fedora-rawhide-x86_64/06757433-rust-crypto-auditing-client/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks good to me now, thank you! === Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification (GPL-3.0-or-later) and is acceptable for Fedora - licenses of statically linked dependencies are correctly taken into account - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-crypto-auditing-client
Thank you for the review! The package has been imported and built in rawhide: https://bodhi.fedoraproject.org/updates/FEDORA-2023-df7a63bd62