Spec URL: https://decathorpe.fedorapeople.org/rust-tracing-indicatif.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-tracing-indicatif-0.3.5-1.fc39.src.rpm Description: Tracing layer that automatically creates and manages progress bars for active spans. Fedora Account System Username: decathorpe
Copr build: https://copr.fedorainfracloud.org/coprs/build/6741552 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254022-rust-tracing-indicatif/fedora-rawhide-x86_64/06741552-rust-tracing-indicatif/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass, both doc tests and unit tests - (!) There's a new version of the crate that was just published (0.3.5 vs. 0.3.6) - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Could you please update the SPEC file to target the latest version of the crate? I think it should also allow you to drop the patch.
Spec URL: https://decathorpe.fedorapeople.org/rust-tracing-indicatif.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-tracing-indicatif-0.3.6-1.fc39.src.rpm Updated to version 0.3.6, dropped upstreamed patch
Created attachment 2004037 [details] The .spec file difference from Copr build 6741552 to 6746733
Copr build: https://copr.fedorainfracloud.org/coprs/build/6746733 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254022-rust-tracing-indicatif/fedora-rawhide-x86_64/06746733-rust-tracing-indicatif/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. - package builds and installs without errors on rawhide - test suite is run and all unit tests pass, both doc tests and unit tests - packages the latest version available upstream (0.3.6) - license matches upstream specification (MIT) and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines Package is APPROVED.
Thank you for the review!
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-tracing-indicatif
Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-9e28eb2b97