Bug 2254151 - Review Request: rust-kbs-types - Rust (de)serializable types for KBS
Summary: Review Request: rust-kbs-types - Rust (de)serializable types for KBS
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/kbs-types
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-12 10:34 UTC by Sergio Lopez
Modified: 2024-01-25 22:08 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-25 22:08:32 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Sergio Lopez 2023-12-12 10:35:51 UTC
This is a new dependency required by libkrun.

Comment 2 Fedora Review Service 2023-12-12 10:45:34 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6743744
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254151-rust-kbs-types/fedora-rawhide-x86_64/06743744-rust-kbs-types/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Fabio Valentini 2023-12-13 15:15:45 UTC
Package looks good to me, with one minor issue that can be fixed before importing:

Please regenerate the package with rpmautospec. It is the default for new packages since Fedora 38:
https://fedoraproject.org/wiki/Changes/Rpmautospec_by_Default

It has also been the default for Rust packages for even longer.

===

Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification (Apache-2.0) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

===

Comment 4 Fedora Admin user for bugzilla script actions 2023-12-20 16:01:39 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-kbs-types


Note You need to log in before you can comment on or make changes to this bug.