Bug 2254616 - Review Request: elementary-mail - Mail app designed for elementary
Summary: Review Request: elementary-mail - Mail app designed for elementary
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/elementary/mail
Whiteboard:
Depends On:
Blocks: PantheonDesktopPackageReviews
TreeView+ depends on / blocked
 
Reported: 2023-12-14 21:57 UTC by Fabio Valentini
Modified: 2023-12-21 20:08 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-21 20:08:56 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Fabio Valentini 2023-12-14 21:57:04 UTC
Spec URL: https://decathorpe.fedorapeople.org/elementary-mail.spec
SRPM URL: https://decathorpe.fedorapeople.org/elementary-mail-7.2.0-1.fc39.src.rpm

Description:
Mail app designed for elementary.

Fedora Account System Username: decathorpe

Comment 1 Fabio Valentini 2023-12-14 21:57:07 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=110347309

Comment 2 Fedora Review Service 2023-12-14 22:10:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6758114
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254616-elementary-mail/fedora-rawhide-x86_64/06758114-elementary-mail/fedora-review/review.txt

Found issues:

- No gcc, gcc-c++ or clang found in BuildRequires
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/elementary-mail
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Neal Gompa 2023-12-15 00:16:57 UTC
Review notes:

* Package (mostly) follows Fedora Packaging Guidelines
  + Please add "BuildRequires: gcc" on import
* Package builds and installs
* Package licensing is correctly handled
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 4 Fabio Valentini 2023-12-18 13:56:32 UTC
Thank you for the review!
I will add BR: gcc before re-importing the package.

Comment 5 Fabio Valentini 2023-12-18 14:03:19 UTC
https://pagure.io/releng/issue/11843

Comment 6 Fabio Valentini 2023-12-21 20:08:56 UTC
Imported and built:
https://bodhi.fedoraproject.org/updates/FEDORA-2023-1cce8a9b58


Note You need to log in before you can comment on or make changes to this bug.