Spec URL: https://music.fedorapeople.org/python-expandvars.spec SRPM URL: https://music.fedorapeople.org/python-expandvars-0.12.0-1.fc39.src.rpm Description: This module is inspired by GNU bash’s variable expansion features. It can be used as an alternative to Python’s os.path.expandvars function. A good use case is reading config files with the flexibility of reading values from environment variables using advanced features like returning a default value if some variable is not defined. Fedora Account System Username: music This is a trivial pure-Python package required for the current version of python-frozenlist, which in turn is a dependency for python-aiohttp and python-aiosignal. I plan to add the new “-l” option for %pyproject_save_files to assert the presence of a properly-packaged license file once pyproject-rpm-macros 1.11.0 reaches stable in all current releases (https://bodhi.fedoraproject.org/updates/?packages=pyproject-rpm-macros). For now, I have manually confirmed it with “rpm -qL -p /python3-expandvars-0.12.0-1.fc40.noarch.rpm” (expected output: /usr/lib/python3.12/site-packages/expandvars-0.12.0.dist-info/licenses/LICENSE). Koji scratch builds: F40: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378314 F39: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378315 F38: https://koji.fedoraproject.org/koji/taskinfo?taskID=110378316
Copr build: https://copr.fedorainfracloud.org/coprs/build/6760098 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254717-python-expandvars/fedora-rawhide-x86_64/06760098-python-expandvars/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated - [x] The License tag reflects the package contents and uses the correct identifiers. - [x] The license text is included and marked with %license. - [x] The package builds successfully in mock. - [x] The package is installable (checked by fedora-review). - [x] There are no relevant rpmlint errors. - [x] The package runs tests in %check. - [x] The latest version is packaged or packaging an earlier version is justified. - [x] The packager considers avoiding confusing `%foo_name` macros. (Not a blocker) - [x] Libraries: The package name has a `python3-` prefix and uses the canonical project name - [x] The pyproject macros are used. - [x] There are no bundled libraries. - [x] The package complies with the Python and general Packaging Guidelines. Package approved! On import, don't forget to add the package to release-monitoring.org. You can give @python-packagers-sig `commit` if you wish` Thanks!
Thank you for the review! I’ve waded into simple Rust reviews lately, so I’ll try to take a look at bug 2254855 when I have some time.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-expandvars
Added to release-monitoring.org: https://release-monitoring.org/project/95228/
Added python-sig with commit privileges and configured Koschei (https://koschei.fedoraproject.org/package/python-expandvars?collection=f40).
FEDORA-2023-d7fbfb0d0d has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2023-d7fbfb0d0d
FEDORA-2023-d7fbfb0d0d has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2023-c4d698b7e9 has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c4d698b7e9
FEDORA-2023-8d65575379 has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d65575379
FEDORA-2023-5a8d22d786 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a8d22d786
FEDORA-2023-5a8d22d786 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5a8d22d786 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5a8d22d786 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-c4d698b7e9 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2023-c4d698b7e9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2023-8d65575379 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-8d65575379 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-8d65575379 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2023-c4d698b7e9 has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-8d65575379 has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2023-5a8d22d786 has been pushed to the Fedora 38 stable repository. If problem still persists, please make note of it in this bug report.