Spec URL: https://albertlarsan.fr/fedpkgs/rust-select/rust-select.spec SRPM URL: https://albertlarsan.fr/fedpkgs/rust-select/rust-select-0.6.0-1.fc40.src.rpm Description: Library to extract useful data from HTML documents, suitable for web scraping Fedora Account System Username: albertlarsan68 Dependency for rust-mdbook The tests are disabled, as they depend on an unmaintained crate.
[fedora-review-service-build] I updated the files to use the rust2rpm.toml file to disable the tests in a less crude way.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6763282 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254820-rust-select/fedora-rawhide-x86_64/06763282-rust-select/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/6763281 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254820-rust-select/fedora-rawhide-x86_64/06763281-rust-select/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # FIXME: no license files detected This needs to be fixed. The MIT license is one of the FOSS licenses that requires redistributed sources to contain a copy of the license text. Please report the missing license text to the upstream project.
The PR is https://github.com/utkarshkukreti/select.rs/pull/77. Can I do anything while waiting for the PR to be accepted?
Give the upstream maintainer a bit of time to address the PR. It looks like they are active on GitHub, so I hope this should not take long. If the PR is not looked at / merged within 1-2 weeks, you can include the license file you added with the PR manually in the package *temporarily* until the upstream project merges the PR.
Looks like your PR was merged - you can include the license file manually from the upstream git repo for now - until it is part of a published release.
Spec URL: https://albertlarsan68.fedorapeople.org/packages/rust-select/rust-select.spec SRPM URL: https://albertlarsan68.fedorapeople.org/packages/rust-select/rust-select-0.6.0-1.fc41.src.rpm Updated the specfile and srpm with the LICENSE file from the repo.
I'm really sorry for the late response here. This review dropped off my radar. The package looks good to me now. === Package was generated with rust2rpm, simplifying the review. ✅ contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (disabled with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files (temporarily included from upstream git) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
If you're still interested in this package, please continue with the process to import it.
This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it.