Spec URL: https://trix.fedorapeople.org/python-murmurhash.spec SRPM URL: https://trix.fedorapeople.org/python-murmurhash-1.0.10-1.fc40.src.rpm This is a dependency on thinc https://github.com/explosion/thinc/blob/master/README.md here: https://github.com/explosion/thinc/blob/master/requirements.txt#L2C7-L2C7 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6765361 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254882-python-murmurhash/fedora-rawhide-x86_64/06765361-python-murmurhash/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
There is only one thing blocking the approval now - tests. The sources contain them so why not run them? First, the project does not use tox so you should change this line: %pyproject_buildrequires -t to %pyproject_buildrequires requirements.txt There are better ways but the dependency on pytest is not declared anywhere else in the project so this is what we have. Then, it's not possible to run the tests from the build folder because it adds sources of murmurhash module into the PYTHONPATH but the tests directory is installed together with the rest of the files, so we can actually run them from buildroot. That requires disabling caching for pytest so we don't have to remove .pytest-cache folder later: %check pushd %{buildroot}/%{python3_sitearch} %pytest -p no:cacheprovider %{pypi_name}/tests popd If you don't want to ship the tests, which I think you don't, you can remove them here before you popd from the installation destination. One non-blocking comment: I'm not a big fan of %{pypi_version}. Why not just put the version into `Version: ` and then use %{version}? You already use %{version} in Source0.
Spec URL: https://trix.fedorapeople.org/python-murmurhash.spec SRPM URL: https://trix.fedorapeople.org/python-murmurhash-1.0.10-2.fc40.src.rpm Here is an update with requested changes Thanks for the review
Created attachment 2006985 [details] The .spec file difference from Copr build 6765361 to 6854917
Copr build: https://copr.fedorainfracloud.org/coprs/build/6854917 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2254882-python-murmurhash/fedora-rawhide-x86_64/06854917-python-murmurhash/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package APPROVED One last thing you might consider adding is `rm -r tests` after `%pytest` in %check to not ship tests. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License", "*No copyright* Public domain". 12 files have unknown license. Detailed output of licensecheck in /home/lbalhar/temp/reviews/2254882-python-murmurhash/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 834 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-murmurhash [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-murmurhash-1.0.10-1.fc40.x86_64.rpm python-murmurhash-debugsource-1.0.10-1.fc40.x86_64.rpm python-murmurhash-1.0.10-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptr4gffwb')] checks: 31, packages: 3 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 0.7 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 python3-murmurhash.x86_64: E: spelling-error ('Cython', 'Summary(en_US) Cython -> Python') python3-murmurhash.x86_64: E: spelling-error ('Cython', '%description -l en_US Cython -> Python') 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 0.1 s Unversioned so-files -------------------- python3-murmurhash: /usr/lib64/python3.12/site-packages/murmurhash/mrmr.cpython-312-x86_64-linux-gnu.so Source checksums ---------------- https://github.com/explosion/murmurhash/archive/refs/tags/v1.0.10.tar.gz#/murmurhash-1.0.10.tar.gz : CHECKSUM(SHA256) this package : 49d3c401a5b221d5b8118c05154a8bae638ccdbfae1292371bbb466da3a86928 CHECKSUM(SHA256) upstream package : 49d3c401a5b221d5b8118c05154a8bae638ccdbfae1292371bbb466da3a86928 Requires -------- python3-murmurhash (rpmlib, GLIBC filtered): libc.so.6()(64bit) python(abi) rtld(GNU_HASH) python-murmurhash-debugsource (rpmlib, GLIBC filtered): Provides -------- python3-murmurhash: python-murmurhash python3-murmurhash python3-murmurhash(x86-64) python3.12-murmurhash python3.12dist(murmurhash) python3dist(murmurhash) python-murmurhash-debugsource: python-murmurhash-debugsource python-murmurhash-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2254882 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api, Python Disabled plugins: Ocaml, Perl, SugarActivity, PHP, fonts, R, Haskell, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-murmurhash