Bug 2254921 - Review Request: perl-Object-Import - Import methods of an object as functions to a package
Summary: Review Request: perl-Object-Import - Import methods of an object as functions...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2254934
TreeView+ depends on / blocked
 
Reported: 2023-12-17 22:41 UTC by Chris Adams
Modified: 2024-02-15 00:59 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-02-06 18:34:25 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Chris Adams 2023-12-17 22:41:25 UTC
Spec URL: https://cmadams.fedorapeople.org/perl-Object-Import/perl-Object-Import.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-Object-Import/perl-Object-Import-1.005-1.fc39.src.rpm
Description:
This module lets you call methods of a certain object more easily by
exporting them as functions to a package. The exported functions are not
called as methods and do not receive an object argument, but instead the
object is fixed at the time you import them with this module.

Fedora Account System Username: cmadams

Comment 3 Jitka Plesnikova 2024-02-06 11:22:45 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Object-Import-1.005-3.fc40.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl-libs
      1 perl(mro)
      1 perl(MRO::Compat)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(:VERSION) >= 5.7.0
      1 perl(warnings) 
Binary requires are Ok.

$ rpm -qp --provides perl-Object-Import-1.005-3.fc40.noarch.rpm | sort | uniq -c
i      1 perl(Object::Import) = 1.005
      1 perl-Object-Import = 1.005-3.fc40
Binary provides are Ok.

$ rpmlint ./perl-Object-Import*
================================ rpmlint session starts ================================
rpmlint: 2.4.0
configuration:
    /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 31, packages: 3
perl-Object-Import.noarch: W: invalid-license Artistic-1.0-Perl
perl-Object-Import.src: W: invalid-license Artistic-1.0-Perl
= 2 packages and 1 specfiles checked; 0 errors, 2 warnings, 0 badness; has taken 0.3 s =
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 4 Fedora Admin user for bugzilla script actions 2024-02-06 14:09:37 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Object-Import

Comment 5 Fedora Update System 2024-02-06 15:16:05 UTC
FEDORA-2024-6fbb818f13 (perl-Object-Import-1.005-3.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-6fbb818f13

Comment 6 Chris Adams 2024-02-06 18:34:25 UTC
Thanks for the review!

Comment 7 Fedora Update System 2024-02-07 01:29:42 UTC
FEDORA-2024-6fbb818f13 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6fbb818f13 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6fbb818f13

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 8 Fedora Update System 2024-02-15 00:59:42 UTC
FEDORA-2024-6fbb818f13 (perl-Object-Import-1.005-3.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.