Bug 2254929 - Review Request: perl-HTTP-Tiny-Paranoid - Safer HTTP::Tiny
Summary: Review Request: perl-HTTP-Tiny-Paranoid - Safer HTTP::Tiny
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Petr Pisar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 2254924
Blocks: 2254933
TreeView+ depends on / blocked
 
Reported: 2023-12-17 22:56 UTC by Chris Adams
Modified: 2024-04-02 01:19 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-04-02 01:19:21 UTC
Type: ---
Embargoed:
ppisar: fedora-review+


Attachments (Terms of Use)

Description Chris Adams 2023-12-17 22:56:57 UTC
Spec URL: https://cmadams.fedorapeople.org/perl-HTTP-Tiny-Paranoid/perl-HTTP-Tiny-Paranoid.spec
SRPM URL: https://cmadams.fedorapeople.org/perl-HTTP-Tiny-Paranoid/perl-HTTP-Tiny-Paranoid-0.07-1.fc39.src.rpm
Description:
This module is a subclass of HTTP::Tiny that performs exactly one
additional function: before connecting, it passes the hostname to
Net::DNS::Paranoid. If the hostname is rejected, then the request is
aborted before a connect is even attempted.

Fedora Account System Username: cmadams

Comment 1 Chris Adams 2023-12-17 22:57:30 UTC
Note: depends on perl-Net-DNS-Paranoid (review BZ 2254924)

Comment 5 Petr Pisar 2024-03-21 08:59:50 UTC
URL and Source0 addresses are usable. Ok.
TODO: Remove a trailing slash from URL tag.

Source0 archive (SHA512: e853c34f4d8ea1a325a48674d0183442f812ee3d9170d31c46a2e4fe1b90e39e9d47c853fcccbe173aad92589f9deff0f724fe8a2b0568661e2c56b2e67c0f1b) is original. Ok.

TODO: Remove deprecated "Group" tag from the spec file.

Summary verified from lib/HTTP/Tiny/Paranoid.pm. Ok.
Description verified from lib/HTTP/Tiny/Paranoid.pm. Ok.
License verified from README, LICENSE, lib/HTTP/Tiny/Paranoid.pm, Makefile.PL, and dist.ini. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Do not build-require run-time dependencies (e.g. "perl(Class::Method::Modifiers)") of code in ./lib. The code is not executed at build time because of no tests. Alternatively, add "perl -c blib/lib/HTTP/Tiny/Paranoid.pm" to %check section to test that the code compiles.

$ rpmlint perl-HTTP-Tiny-Paranoid.spec ../SRPMS/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.src.rpm ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm 
======================================== rpmlint session starts =======================================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-legacy-licenses.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 3

=== 2 packages and 1 specfiles checked; 0 errors, 0 warnings, 6 filtered, 0 badness; has taken 0.3 s ==
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/doc/perl-HTTP-Tiny-Paranoid
-rw-r--r--    1 root     root                      542 Oct 30  2017 /usr/share/doc/perl-HTTP-Tiny-Paranoid/Changes
-rw-r--r--    1 root     root                      361 Oct 30  2017 /usr/share/doc/perl-HTTP-Tiny-Paranoid/README
drwxr-xr-x    2 root     root                        0 Mar  8 01:00 /usr/share/licenses/perl-HTTP-Tiny-Paranoid
-rw-r--r--    1 root     root                    18352 Oct 30  2017 /usr/share/licenses/perl-HTTP-Tiny-Paranoid/LICENSE
-rw-r--r--    1 root     root                     1708 Mar  8 01:00 /usr/share/man/man3/HTTP::Tiny::Paranoid.3pm.gz
-rw-r--r--    1 root     root                     2734 Oct 30  2017 /usr/share/perl5/vendor_perl/HTTP/Tiny/Paranoid.pm
TODO: Own %{perl_vendorlib}/HTTP and %{perl_vendorlib}/HTTP/Tiny directories. The directories could disappear if perl-HTTP-Tiny became architecture-specific.

$ rpm -q --requires -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(Class::Method::Modifiers)
      1 perl(HTTP::Tiny) >= 0.070
      1 perl(Net::DNS::Paranoid)
      1 perl(parent)
      1 perl(strict)
      1 perl(warnings)
      1 perl-libs
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm | sort -f | uniq -c
      1 perl(HTTP::Tiny::Paranoid) = 0.07
      1 perl-HTTP-Tiny-Paranoid = 0.07-4.fc41
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-HTTP-Tiny-Paranoid-0.07-4.fc41.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in Fedora Rawhide (https://koji.fedoraproject.org/koji/taskinfo?taskID=115238845). Ok.

Otherwise, the package is in line with Fedora and Perl packaging guidelines.
Before building this package, please correct the FIX item and consider fixing the TODO items.
This package is APPROVED.

Comment 6 Fedora Admin user for bugzilla script actions 2024-03-21 13:35:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-Tiny-Paranoid

Comment 7 Fedora Update System 2024-03-24 01:43:34 UTC
FEDORA-2024-850f9c7992 (perl-HTTP-Tiny-Paranoid-0.07-4.fc39) has been submitted as an update to Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-850f9c7992

Comment 8 Fedora Update System 2024-03-25 01:49:26 UTC
FEDORA-2024-850f9c7992 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-850f9c7992 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-850f9c7992

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 9 Fedora Update System 2024-04-02 01:19:21 UTC
FEDORA-2024-850f9c7992 (perl-HTTP-Tiny-Paranoid-0.07-4.fc39) has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.