Bug 225500 - Review Request: cycle - Calendar program for women
Review Request: cycle - Calendar program for women
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Michał Bentkowski
Fedora Package Reviews List
Depends On:
  Show dependency treegraph
Reported: 2007-01-30 17:28 EST by Matěj Cepl
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-03-20 17:37:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
wtogami: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Matěj Cepl 2007-01-30 17:28:22 EST
Spec URL: http://www.ceplovi.cz/matej/progs/rpms/cycle.spec
SRPM URL: http://www.ceplovi.cz/matej/progs/rpms/cycle-0.3.1-1.src.rpm
Cycle is a calendar for women. Given a cycle length or statistics for
several periods, it can calculate the days until menstruation, the days
of "safe" sex, the fertile period, and the days to ovulations, and 
define the d.o.b. of a child. It allows the user to write notes and 
helps to supervise the administration of hormonal contraceptive tablets.

Possibilities of the program:
  - Calculate days of menstruation, based on the length of the cycle or 
    on statistics of previous periods.
  - Calculate days of "safe" sex, fertile period and day to ovulations.
  - Definition of D.O.B. (Date Of Birth) of a child
  - Allows to write notes.
  - Helps to supervise reception of hormonal contraceptive tablets.
  - Multiple users allowed. Data is protected by a password for every 

NOTE: This program is not a reliable contraceptive method. It does 
neither help to prevent sexual transmision diseases like AIDS. It is 
just an electronic means of keeping track of some of your medical data 
and extract some statistical conclusions from them. You cannot consider 
this program as a substitute for your gynecologist in any way.
Comment 1 Michał Bentkowski 2007-01-31 12:30:54 EST
Don't you think that the first part of a description is almost identical
as the Possibilities of the program list? It just talks two times about the 
Comment 2 Matěj Cepl 2007-01-31 12:37:24 EST
Sure, will fix.
Comment 3 Michał Bentkowski 2007-01-31 12:48:45 EST
I'll review it.
Comment 4 Michał Bentkowski 2007-01-31 13:52:23 EST
 * dist tag present
 * sources match upstream (8bd5c2f78e7b1a7ac7910de8b9420d93)
!* package is licensed under a GPL license *not* included in %doc 
!* rpmlint output:
cycle.desktop: warning: The 'Application' category is not defined by the 
desktop entry specification.  Please use one of "AudioVideo", "Audio", "Video", 
"Development", "Education", "Game", "Graphics", "Network", "Office", 
"Settings", "System", "Utility" instead
cycle.desktop: warning: Categories values must be one of "AudioVideo", "Audio", 
"Video", "Development", "Education", "Game", "Graphics", "Network", "Office", 
"Settings", "System", "Utility", "Building", "Debugger", "IDE", "GUIDesigner", 
"Profiling", "RevisionControl", "Translation", "Calendar", "ContactManagement", 
"Database", "Dictionary", "Chart", "Email", "Finance", "FlowChart", "PDA", 
"ProjectManagement", "Presentation", "Spreadsheet", "WordProcessor", 
"2DGraphics", "VectorGraphics", "RasterGraphics", "3DGraphics", "Scanning", 
"OCR", "Photography", "Viewer", "DesktopSettings", "HardwareSettings", 
"PackageManager", "Dialup", "InstantMessaging", "IRCClient", "FileTransfer", 
"HamRadio", "News", "P2P", "RemoteAccess", "Telephony", "WebBrowser", 
"WebDevelopment", "Midi", "Mixer", "Sequencer", "Tuner", "TV", 
"AudioVideoEditing", "Player", "Recorder", "DiscBurning", "ActionGame", 
"AdventureGame", "ArcadeGame", "BoardGame", "BlocksGame", "CardGame", 
"KidsGame", "LogicGame", "RolePlaying", "Simulation", "SportsGame", 
"StrategyGame", "Art", "Construction", "Music", "Languages", "Science", 
"Astronomy", "Biology", "Chemistry", "Geology", "Math", "MedicalSoftware", 
"Physics", "Amusement", "Archiving", "Electronics", "Emulator", "Engineering", 
"FileManager", "TerminalEmulator", "Filesystem", "Monitor", "Security", 
"Accessibility", "Calculator", "Clock", "TextEditor", "Core", "KDE", "GNOME", 
"GTK", "Qt", "Motif", "Java", "ConsoleOnly", "Screensaver", "TrayIcon", 
"Applet", "Shell" (found "Utilities")
Application and Utilities categories are now deprecated. Use one of listed 
above instead.

 * latest version is being packaged
 * mock builds fine, however there are gettext dependency listed two times; 
also I would recommend to use python-devel rather than python BR
 * requires and provides:
cycle = 0.3.1-1.fc7
python >= 2.3
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1

python >= 2.3
rpmlib(CompressedFileNames) <= 3.0.4-1

 * package isn't designed to be relocatable
 * package owns all directories well
 * %clean section is present and looks good
 * build root's fine
 * no objections to %files section
 * no scriptlets required
 * no need to any subpackages
 * no .la files
!* gui application, but .desktop file looks bad: wrong categories and X-Fedora 
argument to desktop-file-install ought to be removed as well. Also it refers to 
not existing /usr/share/icons/cycle.xpm path.

There are two identical files: README.Debian and README.Fedora - seems that we 
can get rid of the first one,
README doesn't also look like a helpful file. On the other hand, you forgot to 
There's man file available, so there's no reason not to include it in package
This is not in fact a blocker but your %install section doesn't look clear. I'd 
like to see it more legible.

 * change categories in .desktop file
 * correct Icon path in .desktop
 * get rid of one gettext BR
 * change python BR to python-devel (AFAIK it is safer)
 * remove --add-category=X-Fedora \ from desktop-file-install (we should use an 
X-Fedora category no longer)
 * change (shorten) %description of a package
 * remove README.Debian file
 * include cycle.1 file
 * make %install more legible
Comment 5 Matěj Cepl 2007-01-31 17:53:45 EST
Updated. New URLs:

Spec URL: http://www.ceplovi.cz/matej/progs/rpms/cycle.spec
SRPM URL: http://www.ceplovi.cz/matej/progs/rpms/cycle-0.3.1-2.src.rpm
Comment 6 Michał Bentkowski 2007-01-31 18:31:10 EST
rpmlint is still not quiet:
cycle.desktop: warning: The 'Application' category is not defined by the 
desktop entry specification.  Please use one of "AudioVideo", "Audio", "Video", 
"Development", "Education", "Game", "Graphics", "Network", "Office", 
"Settings", "System", "Utility" instead

Just get rid of 'Application' category because it is deprecated now.
Also, a few things I haven't noticed before:
 * you don't need to pass python dependency, because wxPython already requires
it; so just leave Requires with only wxPython
 * it's surely not Applications/Multimedia. After a short talk at #fedora-extras
I suggest to use Applications/Productivity category (other calendars are put
 * don't gzip man page by hand - rpm does it automatically
Comment 7 Matěj Cepl 2007-02-01 04:10:02 EST
Updated. I have also consulted .spec from the tarball, and although I haven't
accepted everything, I made a small changes to my spec accordingly.

New URL of SRPM: http://www.ceplovi.cz/matej/progs/rpms/cycle-0.3.1-3.src.rpm
Comment 8 Michał Bentkowski 2007-02-01 10:49:02 EST
Looks fine now.
Comment 9 Ruben Kerkhof 2007-02-03 11:38:26 EST
Resetting fedora-review flag to BLANK since this is not part of the Core-Extras Merge review
Comment 10 Mamoru TASAKA 2007-02-25 11:12:54 EST
What is the status of this review request?
Currently this is assigned to nobody...
Comment 11 Michał Bentkowski 2007-02-25 13:02:48 EST
(In reply to comment #10)
> What is the status of this review request?
> Currently this is assigned to nobody...

Hmm, odd... I have approved this package and it ought to be closed as well,
because package exists in repo.
Comment 12 Michał Bentkowski 2007-03-20 13:44:20 EDT
Matej, please close this ticket.
Comment 13 Matěj Cepl 2007-03-20 14:11:24 EDT
Not yet, see
for the proper procedure:

New Package CVS Request
Package Name: cycle
Short Description: Calendar program for women
Owners: mcepl@redhat.com
Branches: FC-5 FC-6
Comment 14 Matěj Cepl 2007-03-20 14:14:27 EDT
Moreover, I am not sure, whether the package is really built in -devel --
doesn't show it

Note You need to log in before you can comment on or make changes to this bug.