Bug 2255196 - Review Request: rust-rustix-openpty - Safe Rust bindings to openpty and related functions
Summary: Review Request: rust-rustix-openpty - Safe Rust bindings to openpty and relat...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/rustix-openpty
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2023-12-19 07:53 UTC by Aleksei Bavshin
Modified: 2023-12-28 01:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2023-12-28 00:53:56 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Comment 1 Fedora Review Service 2023-12-19 08:00:53 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/6769385
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255196-rust-rustix-openpty/fedora-rawhide-x86_64/06769385-rust-rustix-openpty/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2023-12-20 19:03:27 UTC
Package was generated with rust2rpm, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the crate is packaged
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 3 Fedora Admin user for bugzilla script actions 2023-12-21 03:35:29 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rustix-openpty

Comment 4 Fedora Update System 2023-12-21 04:56:43 UTC
FEDORA-2023-5c396ccb27 has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2023-5c396ccb27

Comment 5 Fedora Update System 2023-12-22 02:51:53 UTC
FEDORA-2023-0157f75915 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-0157f75915`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-0157f75915

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2023-12-22 03:38:52 UTC
FEDORA-2023-5c396ccb27 has been pushed to the Fedora 38 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2023-5c396ccb27`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2023-5c396ccb27

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2023-12-28 00:53:56 UTC
FEDORA-2023-5c396ccb27 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2023-12-28 01:23:36 UTC
FEDORA-2023-0157f75915 has been pushed to the Fedora 39 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.