Spec URL: https://trix.fedorapeople.org/python-einops.spec SRPM URL: https://trix.fedorapeople.org/python-einops-0.7.0-1.fc40.src.rpm Flexible and powerful tensor operations for readable and reliable code. Supports numpy, pytorch, tensorflow, jax, and others. This is part of dependency chain for python-fastchat. Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/6784935 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255637-einops/fedora-rawhide-x86_64/06784935-python-einops/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== %check section is missing and the python guidelines specify that at least a smoke test must be run there. You can add something like this after pyproject_install %pyproject_save_files %{pypi_name} %check %pyproject_check_import With this appears a missing dependecy on "chainer". If this failure is expected you can exclude "einops.layers.chainer" passing flags to pyproject_check_import See here https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_test_macros Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [X]: License field in the package spec file matches the actual license. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20726 bytes in 1 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [X]: Binary eggs must be removed in %prep Note: Cannot find any build in BUILD directory (--prebuilt option?) [X]: Python eggs must not download any dependencies during the build process. [X]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-einops-0.7.0-1.fc40.noarch.rpm python-einops-0.7.0-1.fc40.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.4.0 configuration: /usr/lib/python3.11/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpbg1gfc10')] checks: 31, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 badness; has taken 1.5 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-einops.noarch: E: spelling-error ('numpy', '%description -l en_US numpy -> bumpy, lumpy, dumpy') python3-einops.noarch: E: spelling-error ('pytorch', '%description -l en_US pytorch -> PyTorch') python3-einops.noarch: E: spelling-error ('tensorflow', '%description -l en_US tensorflow -> tensor flow, tensor-flow, TensorFlow') python3-einops.noarch: E: spelling-error ('jax', '%description -l en_US jax -> ax, Ajax, sax') 1 packages and 0 specfiles checked; 4 errors, 0 warnings, 3 filtered, 4 badness; has taken 0.2 s Source checksums ---------------- https://github.com/arogozhnikov/einops/archive/refs/tags/v0.7.0.tar.gz#/einops-0.7.0.tar.gz : CHECKSUM(SHA256) this package : ed66c35ac0f9db466352c27d2ae9a9504d592a2c2c552dca58e57baa630c99a6 CHECKSUM(SHA256) upstream package : ed66c35ac0f9db466352c27d2ae9a9504d592a2c2c552dca58e57baa630c99a6 Requires -------- python3-einops (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-einops: python-einops python3-einops python3.12-einops python3.12dist(einops) python3dist(einops)
(In reply to Sergio Pascual from comment #2) > Package Review > ============== > > %check section is missing and the python guidelines specify that at least a > smoke test must be run there. > > > You can add something like this after pyproject_install > > > %pyproject_save_files %{pypi_name} > > %check > %pyproject_check_import > > With this appears a missing dependecy on "chainer". > If this failure is expected you can exclude "einops.layers.chainer" passing > flags to pyproject_check_import > Thanks for pointing this out, this is a problem. I have filed a package review for chainer, it's the depends-on bz 2259226. There is at least one more after that, flax.
My email changed and i lost this bz. I will open up a new review in a bit.
Here is the update with my new email. https://bugzilla.redhat.com/show_bug.cgi?id=2334210 The big change is removing the frameworks that fedora does not support. ex/ chainer is too old and looks dead, tensorflow is not packagable because of bazel. If you have time could you review it ?
Hi, I see that this is already reviewed, son I'm closing the ticket. *** This bug has been marked as a duplicate of bug 2334210 ***