Bug 2255746 - subversion: FTBFS in Fedora Rawhide perhaps due to zlib-ng-compat transition
Summary: subversion: FTBFS in Fedora Rawhide perhaps due to zlib-ng-compat transition
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: subversion
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Tomas Korbar
QA Contact: Fedora Extras Quality Assurance
URL: https://koschei.fedoraproject.org/pac...
Whiteboard:
Depends On:
Blocks: F40FTBFS
TreeView+ depends on / blocked
 
Reported: 2023-12-24 14:24 UTC by Mamoru TASAKA
Modified: 2024-01-12 14:51 UTC (History)
2 users (show)

Fixed In Version: subversion-1.14.3-2.fc40
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2024-01-12 14:51:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Mamoru TASAKA 2023-12-24 14:24:14 UTC
Description of problem:

subversion-1.14.2-22.fc40 began to FTBFS on rawhide (F-40):
https://koschei.fedoraproject.org/package/subversion
https://koji.fedoraproject.org/koji/taskinfo?taskID=110714033

```
FAIL:  patch_tests.py 57: patch a binary file

W: Unexpected output
W: EXPECTED STDOUT (match_all=True):
W: | Index: svn-test-work/working_copies/patch_tests-57/iota
W: | ===================================================================
W: | diff --git a/iota b/iota
W: | GIT binary patch
W: | literal 48
W: | zc$^E#$ShU>qLPeMg|y6^R0Z|S{E|d<JuZf(=9bpB_PpZ!+|-hc%)E52)STkf{{Wp*
W: | B5)uFa
W: | 
W: | literal 25
W: | ec$^E#$ShU>qLPeMg|y6^R0Z|S{E|d<JuU!m{s;*G
W: | 
W: | Property changes on: iota
W: | ___________________________________________________________________
W: | Added: svn:mime-type
W: | ## -0,0 +1 ##
W: | +application/binary
W: | \ No newline at end of property
W: ACTUAL STDOUT:
W: | Index: svn-test-work/working_copies/patch_tests-57/iota
W: | ===================================================================
W: | diff --git a/iota b/iota
W: | GIT binary patch
W: | literal 48
W: | zc$^E#$ShXKELJGVNL5J7%t=*H&&)4LRM+ETXlib0ZEMdf&d*IP$;ix0=Ss~fPW=x6
W: | Dol+7K
W: | 
W: | literal 25
W: | gc$^E#$ShXKELJGVNL5J7%t=*H&&)4LRM+DI0B`;X2><{9
W: | 
W: | Property changes on: iota
W: | ___________________________________________________________________
W: | Added: svn:mime-type
W: | ## -0,0 +1 ##
W: | +application/binary
W: | \ No newline at end of property
W: DIFF STDOUT (match_all=True):
W: | --- EXPECTED STDOUT (match_all=True)
W: | +++ ACTUAL STDOUT
W: | @@ -3,11 +3,11 @@
W: |  diff --git a/iota b/iota
W: |  GIT binary patch
W: |  literal 48
W: | -zc$^E#$ShU>qLPeMg|y6^R0Z|S{E|d<JuZf(=9bpB_PpZ!+|-hc%)E52)STkf{{Wp*
W: | -B5)uFa
W: | +zc$^E#$ShXKELJGVNL5J7%t=*H&&)4LRM+ETXlib0ZEMdf&d*IP$;ix0=Ss~fPW=x6
W: | +Dol+7K
W: | 
W: |  literal 25
W: | -ec$^E#$ShU>qLPeMg|y6^R0Z|S{E|d<JuU!m{s;*G
W: | +gc$^E#$ShXKELJGVNL5J7%t=*H&&)4LRM+DI0B`;X2><{9
W: | 
W: |  Property changes on: iota
W: |  ___________________________________________________________________
W: CWD: /builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline
W: EXCEPTION: SVNLineUnequal
Traceback (most recent call last):
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/main.py", line 1928, in run
    rc = self.pred.run(sandbox)
         ^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/testcase.py", line 178, in run
    result = self.func(sandbox)
             ^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/patch_tests.py", line 5814, in patch_binary_file
    _, diff_output, _ = svntest.actions.run_and_verify_svn(expected_output, [],
                        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/actions.py", line 339, in run_and_verify_svn
    return run_and_verify_svn2(expected_stdout, expected_stderr,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/actions.py", line 379, in run_and_verify_svn2
    verify.verify_outputs("Unexpected output", out, err,
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/verify.py", line 531, in verify_outputs
    compare_and_display_lines(message, label, expected, actual, raisable)
  File "/builddir/build/BUILD/subversion-1.14.2/subversion/tests/cmdline/svntest/verify.py", line 504, in compare_and_display_lines
    raise raisable
svntest.main.SVNLineUnequal
FAIL:  patch_tests.py 57: patch a binary file
```

From koschei BR difference checking and the above error,
I guess subversion binary patch does does some zlib compression / decompression,
and such result changed with zlib -> zlib-ng-compat change:

https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/4JLGQINPVULVM26TGSHWDNGGS2BWBNBZ/#26KLBAQZ4CNVAAINA3O7UQRMA5UNAGKL


Note:
We are now preparing for Fedora 40 ruby3.3 change:
https://fedoraproject.org/wiki/Changes/Ruby_3.3
subversion has BR: ruby-devel and so we are tracking of this package, because
with FTBFS subversion-ruby will also get FTI due to ruby-lib soname change.

Reproducible: Always

Comment 1 Joe Orton 2024-01-11 16:54:48 UTC
Tomas, could you take this one? I'd recommend disabling that test, maybe there's a better option.

Comment 2 Tomas Korbar 2024-01-12 14:08:18 UTC
Yes, subversion uses zlib for compression of binary changes.
Since the test verifies even correctness of the patched file,
i think it is safe to patch the test and leave it there.

Comment 3 Fedora Update System 2024-01-12 14:48:42 UTC
FEDORA-2024-8f75b9231c has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-8f75b9231c

Comment 4 Fedora Update System 2024-01-12 14:51:27 UTC
FEDORA-2024-8f75b9231c has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.