Spec URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi.spec SRPM URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi-4.0.12^20231105git3b7d9a0-1.fc40.src.rpm Description: The PS Move API is an open source library to access the Sony Move Motion Controller via Bluetooth and USB directly from your PC without the need for a PS3. Tracking in 3D space is possible using a PS Eye or any other suitable camera source. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=110836792
Copr build: https://copr.fedorainfracloud.org/coprs/build/6815979 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255842-psmoveapi/fedora-rawhide-x86_64/06815979-psmoveapi/fedora-review/review.txt Found issues: - libusb-compat-0.1 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: libusb-compat-0.1 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "*No copyright* MIT License", "BSD 2-Clause License [generated file]", "*No copyright* GNU Lesser General Public License v2.1 or later", "GNU General Public License, Version 3", "BSD 3-Clause License". 60 files have unknown license. Detailed output of licensecheck in /home/jon/rpmbuild/reviews/psmoveapi/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig, /usr/lib/udev, /usr/lib/udev/rules.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14040 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psmoveapi-devel , psmoveapi-examples , psmoveapi-libs [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: psmoveapi-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-devel-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-doc-4.0.12^20231105git3b7d9a0-1.fc41.noarch.rpm psmoveapi-examples-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-libs-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-debuginfo-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-debugsource-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-4.0.12^20231105git3b7d9a0-1.fc41.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpuxw3od6g')] checks: 32, packages: 8 psmoveapi-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi.x86_64: W: no-manual-page-for-binary psmove psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example_new_api psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-multiple psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-test_navcon psmoveapi-devel.x86_64: W: no-documentation psmoveapi-examples.x86_64: W: no-documentation psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.buildinfo psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libpsmoveapi.so.4.0.12 ========= 8 packages and 0 specfiles checked; 0 errors, 12 warnings, 49 filtered, 0 badness; has taken 0.7 s ========= Rpmlint (debuginfo) ------------------- Checking: psmoveapi-libs-debuginfo-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-examples-debuginfo-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm psmoveapi-debuginfo-4.0.12^20231105git3b7d9a0-1.fc41.x86_64.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptogas1uf')] checks: 32, packages: 3 ========= 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.3 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 psmoveapi-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example_new_api psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-multiple psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-test_navcon psmoveapi.x86_64: W: no-manual-page-for-binary psmove psmoveapi-devel.x86_64: W: no-documentation psmoveapi-examples.x86_64: W: no-documentation psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.buildinfo psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libpsmoveapi.so.4.0.12 9 packages and 0 specfiles checked; 0 errors, 12 warnings, 70 filtered, 0 badness; has taken 2.1 s Source checksums ---------------- https://github.com/thp/psmoveapi/archive/3b7d9a0bc81ca71759e04d4d7bce6ed3d93eac2f/psmoveapi-3b7d9a0bc81ca71759e04d4d7bce6ed3d93eac2f.tar.gz : CHECKSUM(SHA256) this package : 7c893d552514c00d8c7ace6488141e7ff4a4d2b0be5e31b750924576322453e5 CHECKSUM(SHA256) upstream package : 7c893d552514c00d8c7ace6488141e7ff4a4d2b0be5e31b750924576322453e5 Requires -------- psmoveapi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libopencv_calib3d.so.409()(64bit) libopencv_core.so.409()(64bit) libopencv_highgui.so.409()(64bit) libopencv_imgcodecs.so.409()(64bit) libopencv_imgproc.so.409()(64bit) libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libusb-0.1.so.4()(64bit) libusb-1.0.so.0()(64bit) psmoveapi-libs(x86-64) rtld(GNU_HASH) psmoveapi-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) psmoveapi-libs(x86-64) psmoveapi-doc (rpmlib, GLIBC filtered): psmoveapi-examples (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpsmoveapi.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) psmoveapi-libs(x86-64) rtld(GNU_HASH) psmoveapi-libs (rpmlib, GLIBC filtered): libbluetooth.so.3()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhidapi-hidraw.so.0()(64bit) libm.so.6()(64bit) libopencv_calib3d.so.409()(64bit) libopencv_core.so.409()(64bit) libopencv_imgcodecs.so.409()(64bit) libopencv_imgproc.so.409()(64bit) libopencv_videoio.so.409()(64bit) libpsmoveapi.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libv4l2.so.0()(64bit) rtld(GNU_HASH) psmoveapi-debuginfo (rpmlib, GLIBC filtered): psmoveapi-debugsource (rpmlib, GLIBC filtered): Provides -------- psmoveapi: psmoveapi psmoveapi(x86-64) psmoveapi-devel: pkgconfig(psmoveapi) psmoveapi-devel psmoveapi-devel(x86-64) psmoveapi-doc: psmoveapi-doc psmoveapi-examples: psmoveapi-examples psmoveapi-examples(x86-64) psmoveapi-libs: libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) psmoveapi-libs psmoveapi-libs(x86-64) psmoveapi-debuginfo: debuginfo(build-id) psmoveapi-debuginfo psmoveapi-debuginfo(x86-64) psmoveapi-debugsource: psmoveapi-debugsource psmoveapi-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n /home/jon/rpmbuild/SRPMS/psmoveapi-4.0.12^20231105git3b7d9a0-1.fc39.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Ocaml, SugarActivity, R, Haskell, Python, Java, PHP, Perl, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Here is the first pass as what I spotted. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "*No copyright* MIT License", "BSD 2-Clause License [generated file]", "*No copyright* GNU Lesser General Public License v2.1 or later", "GNU General Public License, Version 3", "BSD 3-Clause License". 60 files have unknown license. Detailed output of licensecheck in /home/jon/rpmbuild/reviews/psmoveapi/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. BSD-2-Clause is the only listed and installed license. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig, /usr/lib/udev, /usr/lib/udev/rules.d [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/udev, /usr/lib/udev/rules.d pkgconf-pkg-config systemd-udev [!]: Final provides and requires are sane (see attachments). - Package must not depend on deprecated() packages. Note: libusb-compat-0.1 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ This one might be required if upstream doesn't support a newer libusb. I'm not sure what the policy is here.
Thanks, will get these sorted out. As for: > [!]: Final provides and requires are sane (see attachments). > > - Package must not depend on deprecated() packages. > Note: libusb-compat-0.1 is deprecated, you must not depend on it. > See: https://docs.fedoraproject.org/en-US/packaging- > guidelines/deprecating-packages/ > > This one might be required if upstream doesn't support a newer libusb. I'm not sure what the policy is here. I did some sleuthing, and it appears to be only used by https://github.com/thp/psmoveapi/blob/master/src/utils/sixpair.c ; everything else in the codebase uses either libusb-1.0 or hidapi. Short term, setting PSMOVE_USE_SIXPAIR to OFF should disable this (at the cost of losing the ability to pair navigation controllers) and rid us of the dependency. Long term, this should really be ported to libusb-1.0 (which looks doable, albeit not entirely trivial).
Spec URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi.spec SRPM URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi-4.0.12^20240424git26e1446-1.fc41.src.rpm Changelog: - update to git snapshot 26e1446 - update license tag and document the breakdown - disable sixpair, drop libusb-compat-0.1 BR, document bundling - add missing Requires
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [-]: Provides: bundled(gnulib) in place as required. Note: Sources not installed [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "BSD 2-Clause License", "*No copyright* MIT License", "BSD 2-Clause License [generated file]", "*No copyright* GNU Lesser General Public License v2.1 or later", "BSD 3-Clause License". 61 files have unknown license. Detailed output of licensecheck in /home/jon/rpmbuild/reviews/psmoveapi/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/pkgconfig, /usr/lib/udev/rules.d, /usr/lib/udev [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 14040 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in psmoveapi-devel , psmoveapi-examples , psmoveapi-libs [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: psmoveapi-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-devel-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-doc-4.0.12^20240424git26e1446-1.fc41.noarch.rpm psmoveapi-examples-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-libs-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-debuginfo-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-debugsource-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-4.0.12^20240424git26e1446-1.fc41.src.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpf8q3ox4v')] checks: 32, packages: 8 psmoveapi-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi.x86_64: W: no-manual-page-for-binary psmove psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example_new_api psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-multiple psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-test_navcon psmoveapi-devel.x86_64: W: no-documentation psmoveapi-examples.x86_64: W: no-documentation psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.buildinfo psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libpsmoveapi.so.4.0.12 ============================= 8 packages and 0 specfiles checked; 0 errors, 12 warnings, 49 filtered, 0 badness; has taken 1.2 s ============================= Rpmlint (debuginfo) ------------------- Checking: psmoveapi-libs-debuginfo-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-debuginfo-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm psmoveapi-examples-debuginfo-4.0.12^20240424git26e1446-1.fc41.x86_64.rpm =================================================================== rpmlint session starts =================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpu_7prvf1')] checks: 32, packages: 3 ============================= 3 packages and 0 specfiles checked; 0 errors, 0 warnings, 30 filtered, 0 badness; has taken 0.5 s ============================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 9 psmoveapi-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-example_new_api psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-multiple psmoveapi-examples.x86_64: W: no-manual-page-for-binary psmoveapi-test_navcon psmoveapi.x86_64: W: no-manual-page-for-binary psmove psmoveapi-devel.x86_64: W: no-documentation psmoveapi-examples.x86_64: W: no-documentation psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.buildinfo psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-libs.x86_64: W: binary-or-shlib-calls-gethostbyname /usr/lib64/libpsmoveapi.so.4.0.12 9 packages and 0 specfiles checked; 0 errors, 12 warnings, 70 filtered, 0 badness; has taken 3.1 s Source checksums ---------------- https://github.com/thp/psmoveapi/archive/26e1446fc9b5996192a1f406d289e64e4e97a195/psmoveapi-26e1446fc9b5996192a1f406d289e64e4e97a195.tar.gz : CHECKSUM(SHA256) this package : deb810c27b40438a308e0024ecf4648e304990eaf03c3ebc113f58941be6d2fa CHECKSUM(SHA256) upstream package : deb810c27b40438a308e0024ecf4648e304990eaf03c3ebc113f58941be6d2fa Requires -------- psmoveapi (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libopencv_calib3d.so.409()(64bit) libopencv_core.so.409()(64bit) libopencv_highgui.so.409()(64bit) libopencv_imgcodecs.so.409()(64bit) libopencv_imgproc.so.409()(64bit) libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libusb-1.0.so.0()(64bit) psmoveapi-libs(x86-64) rtld(GNU_HASH) systemd-udev psmoveapi-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) pkgconf-pkg-config psmoveapi-libs(x86-64) psmoveapi-doc (rpmlib, GLIBC filtered): psmoveapi-examples (rpmlib, GLIBC filtered): libSDL2-2.0.so.0()(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libpsmoveapi.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) psmoveapi-libs(x86-64) rtld(GNU_HASH) psmoveapi-libs (rpmlib, GLIBC filtered): libbluetooth.so.3()(64bit) libc.so.6()(64bit) libdbus-1.so.3()(64bit) libdbus-1.so.3(LIBDBUS_1_3)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libhidapi-hidraw.so.0()(64bit) libm.so.6()(64bit) libopencv_calib3d.so.409()(64bit) libopencv_core.so.409()(64bit) libopencv_imgcodecs.so.409()(64bit) libopencv_imgproc.so.409()(64bit) libopencv_videoio.so.409()(64bit) libpsmoveapi.so.4.0.12()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libv4l2.so.0()(64bit) rtld(GNU_HASH) psmoveapi-debuginfo (rpmlib, GLIBC filtered): psmoveapi-debugsource (rpmlib, GLIBC filtered): Provides -------- psmoveapi: bundled(sixad) psmoveapi psmoveapi(x86-64) psmoveapi-devel: pkgconfig(psmoveapi) psmoveapi-devel psmoveapi-devel(x86-64) psmoveapi-doc: psmoveapi-doc psmoveapi-examples: psmoveapi-examples psmoveapi-examples(x86-64) psmoveapi-libs: libpsmoveapi.so.4.0.12()(64bit) libpsmoveapi_tracker.so.4.0.12()(64bit) psmoveapi-libs psmoveapi-libs(x86-64) psmoveapi-debuginfo: debuginfo(build-id) psmoveapi-debuginfo psmoveapi-debuginfo(x86-64) psmoveapi-debugsource: psmoveapi-debugsource psmoveapi-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n psmoveapi-4.0.12^20240424git26e1446-1.fc41.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, PHP, SugarActivity, Ocaml, fonts, Python, R, Perl, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[?]: Package functions as described. I have no way to test this. The only remaining feedback is to consider addressing the following rpmlint complaints: psmoveapi-doc.noarch: W: python-sphinx-doctrees-leftover /usr/share/doc/psmoveapi-doc/html/.doctrees psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.buildinfo psmoveapi-doc.noarch: W: hidden-file-or-dir /usr/share/doc/psmoveapi-doc/html/.doctrees I missed the upstream newer commit and hadn't checked it. Confirmed this update is the latest and will be sure to always check in the future.
Spec URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi.spec SRPM URL: https://dcavalca.fedorapeople.org/review/psmoveapi/psmoveapi-4.0.12^20240424git26e1446-1.fc41.src.rpm Changelog: - delete sphinx cruft
Created attachment 2030769 [details] The .spec file difference from Copr build 6815979 to 7397276
Copr build: https://copr.fedorainfracloud.org/coprs/build/7397276 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255842-psmoveapi/fedora-rawhide-x86_64/07397276-psmoveapi/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/psmoveapi
FEDORA-2024-6d006d8180 (psmoveapi-4.0.12^20240424git26e1446-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6d006d8180
FEDORA-2024-6d006d8180 (psmoveapi-4.0.12^20240424git26e1446-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-635040d7ad (psmoveapi-4.0.12^20240424git26e1446-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-635040d7ad
FEDORA-2024-71bb2c5d5a (psmoveapi-4.0.12^20240424git26e1446-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-71bb2c5d5a
FEDORA-2024-b64b19ffb6 (psmoveapi-4.0.12^20240424git26e1446-1.fc38) has been submitted as an update to Fedora 38. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b64b19ffb6
FEDORA-2024-b64b19ffb6 has been pushed to the Fedora 38 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b64b19ffb6 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b64b19ffb6 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-71bb2c5d5a has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-71bb2c5d5a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-71bb2c5d5a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-635040d7ad has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-635040d7ad \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-635040d7ad See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.