Spec URL: https://dcavalca.fedorapeople.org/review/percetto/percetto.spec SRPM URL: https://dcavalca.fedorapeople.org/review/percetto/percetto-0.1.6-1.fc40.src.rpm Description: PerCetto is a minimal C wrapper for Perfetto SDK to enable app-specific tracing. Internally, there is a minimal implementation of TrackEvent data source. Fedora Account System Username: dcavalca
Copr build: https://copr.fedorainfracloud.org/coprs/build/6815983 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2255875-percetto/fedora-rawhide-x86_64/06815983-percetto/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Spec URL: https://dcavalca.fedorapeople.org/review/percetto/percetto.spec SRPM URL: https://dcavalca.fedorapeople.org/review/percetto/percetto-0.1.6-1.fc42.src.rpm Changelog: - rebuild for f42
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0". 3 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/percetto/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1603 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/olvaffe/percetto/archive/0.1.6/percetto-0.1.6.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: percetto-0.1.6-1.fc42.x86_64.rpm percetto-devel-0.1.6-1.fc42.x86_64.rpm percetto-debuginfo-0.1.6-1.fc42.x86_64.rpm percetto-debugsource-0.1.6-1.fc42.x86_64.rpm percetto-0.1.6-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp54svlaca')] checks: 32, packages: 5 percetto-devel.x86_64: W: no-documentation ========= 5 packages and 0 specfiles checked; 0 errors, 1 warnings, 40 filtered, 0 badness; has taken 0.6 s ========== Rpmlint (debuginfo) ------------------- Checking: percetto-debuginfo-0.1.6-1.fc42.x86_64.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpqblhduv_')] checks: 32, packages: 1 ========= 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.3 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 percetto-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 1 warnings, 37 filtered, 0 badness; has taken 0.6 s Requires -------- percetto (rpmlib, GLIBC filtered): libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libpercetto.so.0.1.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.5)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) percetto-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libpercetto-atrace.so.0.1.6()(64bit) libpercetto.so.0.1.6()(64bit) percetto(x86-64) percetto-debuginfo (rpmlib, GLIBC filtered): percetto-debugsource (rpmlib, GLIBC filtered): Provides -------- percetto: libpercetto-atrace.so.0.1.6()(64bit) libpercetto.so.0.1.6()(64bit) percetto percetto(x86-64) percetto-devel: percetto-devel percetto-devel(x86-64) pkgconfig(percetto) pkgconfig(percetto-atrace) percetto-debuginfo: debuginfo(build-id) libpercetto-atrace.so.0.1.6-0.1.6-1.fc42.x86_64.debug()(64bit) libpercetto.so.0.1.6-0.1.6-1.fc42.x86_64.debug()(64bit) percetto-debuginfo percetto-debuginfo(x86-64) percetto-debugsource: percetto-debugsource percetto-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n percetto-0.1.6-1.fc42.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Python, R, Perl, Haskell, PHP, SugarActivity, fonts, Ocaml, Java Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/olvaffe/percetto/archive/0.1.6/percetto-0.1.6.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [!]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Update the source URL. [!]: Latest version is packaged. There is not an official release, but should we consider just taking the latest commit? [!]: %check is present and all tests pass. No upstream tests. This is fine.
Spec URL: https://dcavalca.fedorapeople.org/review/percetto/percetto.spec SRPM URL: https://dcavalca.fedorapeople.org/review/percetto/percetto-0.1.6-1.fc42.src.rpm Changelog: - fix URL - Backport upstream fix
> There is not an official release, but should we consider just taking the latest commit? There's only two useful commits so I just backported them directly.
Hmm.. Upstream source is still failing: INFO: Downloading (Source0): https://github.com/olvaffe/percetto/archive/0.1.6/percetto-0.1.6.tar.gz WARNING: Cannot download url: https://github.com/olvaffe/percetto/archive/0.1.6/percetto-0.1.6.tar.gz INFO: No upstream for (Source0): percetto-0.1.6.tar.gz
Sorry, forgot to reupload the src.rpm, please try again.
APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/percetto
FEDORA-2024-32366c6cea (percetto-0.1.6-2.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-32366c6cea
FEDORA-2024-32366c6cea (percetto-0.1.6-2.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.